Repository navigation
refactor(frontend): drop test temporaries, explain the reused-run release and stop shadowing real - #1341
Merged
Conversation
…ease and stop shadowing real Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Clears the SonarCloud findings on
developunderinternal/frontendthat no in-flight PR touches:go:S978x3 inmcp/toolkit/root.go: the localrealshadowed the predeclaredreal; it isresolvednow, with the comments following.go:S1186ingrpc/run_options.go: the no-opreleasefor a reused performance says why it has nothing to release.godre:S8193x2 ingrpc/convert_check_diagnostics_test.goandgrpc/run_options_performer_test.go: temporaries compared once are inlined.No behaviour change, no changelog fragment.
Deferred from this group:
go:S3776onrenderRelatedinlsp/render.go, which #1320 edits; it lands after that PR.A pull request gets no SonarCloud analysis (the CircleCI
scanjob runs ondevelopandmainonly); the proof that these findings clear is the post-merge scan ofdevelop.How it was verified
gofmt -l .empty,go build ./...,go vet ./...,make lint,go test ./internal/frontend/grpc ./internal/frontend/mcp/toolkit ./tests/hygienepass locally.Checklist
make testandmake lintpass locallychanges/unreleased/<slug>.<section>.md, not as an edit toCHANGELOG.mdmake docs-countsrun if a gate count moved (compliance rows need nothing: the census is counted at docs build)F4,K5) in the body, docs, or changelogLink to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/c2b1ac4ad6de4d8788e78fd86c7c1729
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/c2b1ac4ad6de4d8788e78fd86c7c1729?variant=devin
Requested by: @HuiJun