Skip to content

refactor(frontend): drop test temporaries, explain the reused-run release and stop shadowing real - #1341

Merged
HuiJun merged 1 commit into
developfrom
fix/sonar-frontend
Oct 21, 2026
Merged

HuiJun merged 1 commit into
developfrom
fix/sonar-frontend

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

What and why

Clears the SonarCloud findings on develop under internal/frontend that no in-flight PR touches:

  • go:S978 x3 in mcp/toolkit/root.go: the local real shadowed the predeclared real; it is resolved now, with the comments following.
  • go:S1186 in grpc/run_options.go: the no-op release for a reused performance says why it has nothing to release.
  • godre:S8193 x2 in grpc/convert_check_diagnostics_test.go and grpc/run_options_performer_test.go: temporaries compared once are inlined.

No behaviour change, no changelog fragment.

Deferred from this group: go:S3776 on renderRelated in lsp/render.go, which #1320 edits; it lands after that PR.

A pull request gets no SonarCloud analysis (the CircleCI scan job runs on develop and main only); the proof that these findings clear is the post-merge scan of develop.

How it was verified

gofmt -l . empty, go build ./..., go vet ./..., make lint, go test ./internal/frontend/grpc ./internal/frontend/mcp/toolkit ./tests/hygiene pass locally.

Checklist

  • make test and make lint pass locally
  • Tests added or updated for the change
  • Documentation extended where it already covers the surface (see CONTRIBUTING.md)
  • Changelog entry added as changes/unreleased/<slug>.<section>.md, not as an edit to CHANGELOG.md
  • baselines regenerated and make docs-counts run if a gate count moved (compliance rows need nothing: the census is counted at docs build)
  • No internal work-item labels (waves, slices, F4, K5) in the body, docs, or changelog

Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/c2b1ac4ad6de4d8788e78fd86c7c1729
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/c2b1ac4ad6de4d8788e78fd86c7c1729?variant=devin
Requested by: @HuiJun

…ease and stop shadowing real

Co-Authored-By: jason.han <hanhuijun@gmail.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@devin-ai-integration
devin-ai-integration Bot marked this pull request as ready for review October 21, 2026 08:41
@HuiJun
HuiJun merged commit c586528 into develop Oct 21, 2026
50 checks passed
@HuiJun
HuiJun deleted the fix/sonar-frontend branch October 21, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant