Repository navigation
refactor(export): split the stale-text demotion into candidate rebuild and restated checks - #1342
Open
devin-ai-integration[bot] wants to merge 4 commits into
Open
devin-ai-integration[bot] wants to merge 4 commits into
devin-ai-integration[bot] wants to merge 4 commits into
Conversation
…d and restated checks Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-Authored-By: jason.han <hanhuijun@gmail.com>
…stated verbatim writer The baseline pins a source digest of internal/translate/export, so splitting the stale-text demotion moved it. Re-recorded over the full pinned corpora: the only other movement (typeMismatch 1742→1743, extensionProperties 140676→140679) is reproduced with develop's own verbatim.go, so it is develop's drift since the 2026-10-20 record, not a change of this refactor. Co-Authored-By: jason.han <hanhuijun@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Clears
go:S3776on(*decoder).demoteStaleininternal/translate/export/verbatim.go. Choosing the id form the document follows and re-encoding the candidate in it is nowrebuildCandidate; deciding that a disagreeing triple only restates a disagreement that counts elsewhere (referent membership, library reference, implied relationship ends) isrestatesAnotherDisagreement.demoteStalekeeps the loop that blames the printed text. Pure refactor, no behaviour change, no changelog fragment.A pull request gets no SonarCloud analysis (the CircleCI
scanjob runs ondevelopandmainonly); the proof that these findings clear is the post-merge scan ofdevelop.How it was verified
gofmt -l .empty,go build ./...,go vet ./...,make lint,go test ./internal/translate/export ./tests/export ./tests/hygienepass locally (the pilot-corpora gated round trips skip without the corpora). The SonarCloud analyzer run over the file reports no finding.Checklist
make testandmake lintpass locallychanges/unreleased/<slug>.<section>.md, not as an edit toCHANGELOG.mdmake docs-countsrun if a gate count moved (compliance rows need nothing: the census is counted at docs build)F4,K5) in the body, docs, or changelogLink to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/c2b1ac4ad6de4d8788e78fd86c7c1729
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/c2b1ac4ad6de4d8788e78fd86c7c1729?variant=devin
Requested by: @HuiJun
Baseline re-record
docs/project/api-json-differential-baseline.jsonpins a source digest ofinternal/translate/export, so this refactor moved it andtools/referee/apijsonfailed in CI. The baseline is re-recorded over the full pinned corpora (go run -C tools ./cmd/pilot-apijson-diff -update). Besides the digest and the date, three counters move (typeMismatch1742→1743,extensionProperties140676→140679, one root 390→391); the same run with develop's ownverbatim.gomoves exactly those three and leaves the digest alone, so they are develop's drift since the 2026-10-20 record and this refactor changes no verdict. #1333, #1331, #1328 and #1232 also re-record this file; whichever lands second re-records the digest line.