Skip to content

fix(vscode): read the declared extension version only when package.json states a string - #1343

Merged
HuiJun merged 2 commits into
developfrom
fix/sonar-vscode
Oct 21, 2026
Merged

HuiJun merged 2 commits into
developfrom
fix/sonar-vscode

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

What and why

Clears typescript:S6551 in editors/vscode/src/extension.ts: the extension version was read with String(...) over an unknown, which would have turned an object into [object Object]. The version is now used only when package.json declares a string and is empty otherwise, which is what every consumer of extensionVersion expects. No changelog fragment: the shipped package.json always declares a string, so no user-visible behaviour changes.

Deferred from this group: typescript:S107 and typescript:S3358 in src/webview/layout.ts, which #1336 edits; they land after that PR. The typescript:S2871 bug in src/webview/diagram.ts is already fixed on develop and leaves the next scan.

A pull request gets no SonarCloud analysis (the CircleCI scan job runs on develop and main only); the proof that these findings clear is the post-merge scan of develop.

How it was verified

npm test in editors/vscode passes (with client/node dependencies installed, as CI does); go test ./tests/hygiene passes. The SonarCloud analyzer run over the file reports no finding.

Checklist

  • make test and make lint pass locally
  • Tests added or updated for the change
  • Documentation extended where it already covers the surface (see CONTRIBUTING.md)
  • Changelog entry added as changes/unreleased/<slug>.<section>.md, not as an edit to CHANGELOG.md
  • baselines regenerated and make docs-counts run if a gate count moved (compliance rows need nothing: the census is counted at docs build)
  • No internal work-item labels (waves, slices, F4, K5) in the body, docs, or changelog

Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/c2b1ac4ad6de4d8788e78fd86c7c1729
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/c2b1ac4ad6de4d8788e78fd86c7c1729?variant=devin
Requested by: @HuiJun

…on states a string

Co-Authored-By: jason.han <hanhuijun@gmail.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

devin-ai-integration[bot]

This comment was marked as resolved.

…lper

Co-Authored-By: jason.han <hanhuijun@gmail.com>
@devin-ai-integration
devin-ai-integration Bot marked this pull request as ready for review October 21, 2026 08:41
@HuiJun
HuiJun merged commit 0de155c into develop Oct 21, 2026
42 checks passed
@HuiJun
HuiJun deleted the fix/sonar-vscode branch October 21, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant