Repository navigation
fix(vscode): read the declared extension version only when package.json states a string - #1343
Merged
Merged
Conversation
…on states a string Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
…lper Co-Authored-By: jason.han <hanhuijun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Clears
typescript:S6551ineditors/vscode/src/extension.ts: the extension version was read withString(...)over anunknown, which would have turned an object into[object Object]. The version is now used only whenpackage.jsondeclares a string and is empty otherwise, which is what every consumer ofextensionVersionexpects. No changelog fragment: the shippedpackage.jsonalways declares a string, so no user-visible behaviour changes.Deferred from this group:
typescript:S107andtypescript:S3358insrc/webview/layout.ts, which #1336 edits; they land after that PR. Thetypescript:S2871bug insrc/webview/diagram.tsis already fixed ondevelopand leaves the next scan.A pull request gets no SonarCloud analysis (the CircleCI
scanjob runs ondevelopandmainonly); the proof that these findings clear is the post-merge scan ofdevelop.How it was verified
npm testineditors/vscodepasses (withclient/nodedependencies installed, as CI does);go test ./tests/hygienepasses. The SonarCloud analyzer run over the file reports no finding.Checklist
make testandmake lintpass locallychanges/unreleased/<slug>.<section>.md, not as an edit toCHANGELOG.mdmake docs-countsrun if a gate count moved (compliance rows need nothing: the census is counted at docs build)F4,K5) in the body, docs, or changelogLink to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/c2b1ac4ad6de4d8788e78fd86c7c1729
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/c2b1ac4ad6de4d8788e78fd86c7c1729?variant=devin
Requested by: @HuiJun