Repository navigation
refactor(scripts): tidy shell, node and python helpers the quality scan flagged - #1344
Merged
Merged
Conversation
…an flagged Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Clears the SonarCloud findings on
developacross the scripts and packaging helpers:shelldre:S131inscripts/install-mcp-publisher.sh: the architecturecasestates its default (any other machine name is looked up asunamespells it).shelldre:S7679x3 inscripts/npm-publish-missing.sh:manifestnames its parameter instead of reading$1three times.javascript:S4624inscripts/mcp-stdio-probe.mjs: the nested template literal is a named value.javascript:S6582inpackaging/npm/sysml-mcp/lib/platform.js: optional chaining for the error code.python:S1192inclient/python/scripts/check_version.py:package.jsonis one constant.The two
shell:S6506vulnerabilities inscripts/install-mcp-publisher.shandscripts/mcp-registry-publish.shand thetext:S8564lock-file finding onpackaging/npm/sysml-mcp/package.jsonare already fixed ondevelopand leave the next scan. No behaviour change, no changelog fragment.Deferred from this group:
java:S3776andjava:S127x3 inscripts/pilot-json-exporter/ExportJSON.java, which #1328 edits; they land after that PR.A pull request gets no SonarCloud analysis (the CircleCI
scanjob runs ondevelopandmainonly); the proof that these findings clear is the post-merge scan ofdevelop.How it was verified
shellcheckover both scripts is clean;node --checkover both JavaScript files;npm testinpackaging/npm/sysml-mcp(23 tests) andpytest client/python/tests/test_check_version.py(85 tests) pass;go test ./tests/hygienepasses;make lintpasses. The SonarCloud analyzer run over each edited file reports no finding.Checklist
make testandmake lintpass locallychanges/unreleased/<slug>.<section>.md, not as an edit toCHANGELOG.mdmake docs-countsrun if a gate count moved (compliance rows need nothing: the census is counted at docs build)F4,K5) in the body, docs, or changelogLink to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/c2b1ac4ad6de4d8788e78fd86c7c1729
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/c2b1ac4ad6de4d8788e78fd86c7c1729?variant=devin
Requested by: @HuiJun