Repository navigation
refactor(tools): split the long command drivers and referees into named steps - #1346
Merged
Merged
Conversation
…ed steps Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Co-Authored-By: jason.han <hanhuijun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Clears the SonarCloud findings on
developundertools/, allgo:S3776but one:bench/llm/main.gorunCommand: flag parsing and option validation areparseRunOptions; the arm list isparseArms; opening a replay or live provider isproviderFor; starting the results file isnewResults; writing the fixture and results after each cell issaveProgress.cmd/conformance/main.gorunSuite: validating the options against each other isplanSuite(asuitePlan); building the binaries the plan lacks isbuildMissingBinaries; one capability configuration isrunConfigurationwith aconfigurationRunwhoseprotocolmethod opens a client, checks its capabilities and runs the scenarios; the reports and exit error arefinishSuite.oracle/specexamples/extract.goExtract: the line scanner is anextractorwithscan,turnPage,blankLine,accumulateandflush, replacing the closure over eight locals.oracle/specexamples/main.gogo:S1192: the pin stamp file name is one constant,pinStamp.referee/apijson/ours.goexportOurs: reading and parsing isparseDocuments, converting each document alone isconvertAlone, and finding the documents whose ids collide iscollidingIDs.referee/flexo/library.gomeasureUserModelandlibraryFindings: following each typing into the library isfollowTypings, re-converting the delivered model to notation isreadBackNotation, declaring theProjectUsageisdeclareLibraryUsage, and the user-model lines of the findings areuserModelFindings.Each helper holds the code it replaced, moved verbatim; no changelog fragment.
Behaviour changes
Two in
bench/llm run, both on invalid or odd flag sets:-roundsbelow zero is refused while the flags are parsed, before the toolchain, corpus or provider are opened; a command line that is wrong in both ways now reports the rounds first, where it reported the toolchain first.-arms=mcp,mcpstarts one MCP server. The old loop started one per entry but kept only the last inrunner.MCP(the earlier ones ran unused until exit), so the one server is the behaviour every cell already had.A pull request gets no SonarCloud analysis (the CircleCI
scanjob runs ondevelopandmainonly); the proof that these findings clear is the post-merge scan ofdevelop.How it was verified
gofmt -l .empty,go build ./...andgo vet ./...in thetoolsmodule,make lint(both modules),go test ./bench/llm ./cmd/conformance ./oracle/specexamples ./referee/apijson ./referee/flexointoolsandgo test ./tests/hygienepass locally. The SonarCloud analyzer run over each edited file reports no finding (it caught twogo:S107parameter-count findings in the first cut of the split, which theconfigurationRunstruct and theanyElementargument remove).Checklist
make testandmake lintpass locallychanges/unreleased/<slug>.<section>.md, not as an edit toCHANGELOG.mdmake docs-countsrun if a gate count moved (compliance rows need nothing: the census is counted at docs build)F4,K5) in the body, docs, or changelogLink to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/c2b1ac4ad6de4d8788e78fd86c7c1729
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/c2b1ac4ad6de4d8788e78fd86c7c1729?variant=devin
Requested by: @HuiJun