Repository navigation
docs(perf): measure the shipping 0.11.0 head against 0.10.1 - #1371
Merged
Merged
Conversation
Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Contributor
Author
There was a problem hiding this comment.
🔍 Devin Review: 4 flags
Not posted on this PR by your GitHub settings — view them in Devin Review. (Configure)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The 0.11.0 performance record that merged with #1337 measured an earlier candidate (
developatd8b60ed62with #1350 merged on top) and describeddevelopas not having moved; by the time it merged, every fix it named had merged too anddevelophad advanced by 23 further merges. This rewritesdocs/project/performance-release-0.11.0-vs-0.10.1.mdas a measurement of the head the release is cut from,5db0f74158f1ecd43509d90141e5055cb0c3e539, against thev0.10.1tag:v0.10.1,benchstatover both; one candidate column instead of three;internal/exec/runtime,internal/frontend/{repl,lsp,grpc},internal/workspace/model, thetests/perfrows whose loaded time had moved and the 32-satellite stress rows, which is every time in the tables not marked †;sysml47.60 → 49.32 MiB);RenameWarmnow allocates less than 0.10.1 andReferencesCold2.8× more (perf(resolve): keep the members an import surfaces for the query asking again #1358's first enumeration per import, a named design cost);DecodeSnapshot+6.8% is perf(semantics): read a library symbol's implied generals from its record #1357's recorded implied generals;Instantiate2.51 M → 6.34 M allocations,BatchSatisfy+93%,FeaturesOf+56%,GRPCVerifyConstraint+50%, bisected to fix(runtime): nested action and state usages are performances their owner holds #1310 and fix(runtime): bind a nested requirement usage's subject from the owning object #1312. The avoidable parts are fixed in perf(semantics): decide a member's root restatement once per symbol #1368 (semantics: the root-restatement walk memoized per symbol) and perf(runtime): read a declaration's member from its scope's index #1369 (runtime: a declaration's member read from the scope's index), whose six quiet rounds are the record's third column where it appears (with both,Instantiate2.22 M, below 0.10.1);GRPCVerifyConstraint's +4.9 k is fix(runtime): nested action and state usages are performances their owner holds #1310's own work and is carried.The record also states what the quiet pass leaves unexplained: four executor rows with identical allocation counts that moved +16–24% on time at p = 0.009–0.026, carried as time unexplained by allocation rather than attributed. The changelog fragment's wording is adjusted to name the head measured;
mkdocs.yml,docs/project/README.mdanddocs/internals/performance.mdalready link the record and are unchanged. No implementation code is in this PR.How it was verified
python3 scripts/check-doc-ids.py,python3 scripts/changelog.py check,python -m mkdocs build --strict,go test ./tests/hygieneclean.python3 scripts/check-doc-links.pyreports one broken link indocs/project/third-party-notices.md(../assets/landing/libavoid-js.LICENSE.txt), which is the same ondevelopand not touched here.benchstattables and the whole-binary runs are reproducible from the method section; the two fix PRs carry their own A/B tables.Checklist
make testandmake lintpass locally (docs gates above; no code changed)changes/unreleased/perf-0.11.0-record.added.md(wording updated), not as an edit toCHANGELOG.mdmake docs-countsrun if a gate count moved (none moved)Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/cf22d7a746814d20b2f0eaf11682fef9
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/cf22d7a746814d20b2f0eaf11682fef9?variant=devin
Requested by: @HuiJun