Skip to content

Update php-laravel to newer versions #24196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wing328 merged 10 commits into from
Jul 15, 2026
Merged

Update php-laravel to newer versions #24196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8f19d09
update php laravel to newer versions
wing328 Jul 3, 2026
468633d
update worfklow
wing328 Jul 3, 2026
54065b4
update workflow
wing328 Jul 3, 2026
d1137fd
update workflow
wing328 Jul 3, 2026
3ac24ce
use custom spec
wing328 Jul 3, 2026
2b5f64f
use custom spec
wing328 Jul 3, 2026
ce89624
update
wing328 Jul 3, 2026
d89e689
update
wing328 Jul 3, 2026
28595ac
update
wing328 Jul 3, 2026
2d4496f
update
wing328 Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions .github/workflows/samples-php-servers-phpstan.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
name: Samples php-laravel 8.x

on:
push:
paths:
- samples/server/petstore/php-laravel/**
- samples/server/petstore/php-laravel-issue-21334/**
pull_request:
paths:
- samples/server/petstore/php-laravel/**
- samples/server/petstore/php-laravel-issue-21334/**
jobs:
build:
name: Build
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
php:
- "8.3"
- "8.4"
sample:
# servers
# comment out due to errors
#- samples/server/petstore/php-laravel/
- samples/server/petstore/php-laravel-issue-21334/
steps:
- uses: actions/checkout@v7
- name: Setup PHP with tools
uses: shivammathur/setup-php@v2
with:
php-version: "${{ matrix.php }}"
- name: composer install
working-directory: ${{ matrix.sample }}
run: composer install
- name: phpstan
working-directory: ${{ matrix.sample }}
run: |
composer require --dev phpstan/phpstan
vendor/bin/phpstan analyse Api Http Model routes.php

@cubic-dev-ai cubic-dev-ai Bot Jul 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: No phpstan.neon or phpstan.neon.dist exists in the sample directory, so PHPStan defaults to level 0 (basic checks only). The analysis will miss type-safety issues, missing return types, and dead code that a higher level would catch — limiting the value of running static analysis at all.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/samples-php-servers-phpstan.yaml, line 40:

<comment>No `phpstan.neon` or `phpstan.neon.dist` exists in the sample directory, so PHPStan defaults to level 0 (basic checks only). The analysis will miss type-safety issues, missing return types, and dead code that a higher level would catch — limiting the value of running static analysis at all.</comment>

<file context>
@@ -0,0 +1,40 @@
+        working-directory: ${{ matrix.sample }}
+        run: |
+          composer require --dev phpstan/phpstan
+          vendor/bin/phpstan analyse Api Http Model routes.php
</file context>

6 changes: 0 additions & 6 deletions .github/workflows/samples-php8.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,10 @@ on:
paths:
- samples/server/petstore/php-symfony/SymfonyBundle-php/**
- samples/server/petstore/php-flight/**
- samples/server/petstore/php-laravel/**
- samples/server/petstore/php-laravel-issue-21334/**
pull_request:
paths:
- samples/server/petstore/php-symfony/SymfonyBundle-php/**
- samples/server/petstore/php-flight/**
- samples/server/petstore/php-laravel/**
- samples/server/petstore/php-laravel-issue-21334/**
jobs:
build:
name: Build PHP projects
Expand All @@ -29,8 +25,6 @@ jobs:
# servers
- samples/server/petstore/php-symfony/SymfonyBundle-php/
- samples/server/petstore/php-flight/
- samples/server/petstore/php-laravel/
- samples/server/petstore/php-laravel-issue-21334/
steps:
- uses: actions/checkout@v7
- name: Setup PHP with tools
Expand Down
2 changes: 1 addition & 1 deletion bin/configs/php-laravel.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
generatorName: php-laravel
outputDir: samples/server/petstore/php-laravel
inputSpec: modules/openapi-generator/src/test/resources/3_0/petstore-with-fake-endpoints-models-for-testing.yaml
inputSpec: modules/openapi-generator/src/test/resources/3_0/php-laravel/petstore-with-fake-endpoints-models-for-testing.yaml
templateDir: modules/openapi-generator/src/main/resources/php-laravel
gitUserId: openapitools
gitRepoId: petstore
6 changes: 3 additions & 3 deletions modules/openapi-generator/src/main/resources/php-laravel/composer.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,12 @@
}
],
"require": {
"php": "^8.1",
"laravel/framework": "^10.0",
"php": "^8.3",
"laravel/framework": "^13.0",
"crell/serde": "^1.0"
},
"require-dev": {
"phpunit/phpunit": "^9.5"
"phpunit/phpunit": "^12.0"
},
"autoload": {
"psr-4": {
Expand Down
Loading
Loading