Rename ruby-idiomatic to ruby-nextgen - #24281
Merged
Merged
Conversation
wing328
marked this pull request as ready for review
July 13, 2026 07:14
Contributor
There was a problem hiding this comment.
1 issue found across 795 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/rubynextgen/RubyApiRouting.java">
<violation number="1" location="modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/rubynextgen/RubyApiRouting.java:10">
P3: The class-level Javadoc comment has a typo: `ruby-nextgengenerator` is missing a space. It should read `ruby-nextgen generator` to match the original comment's readability.</violation>
</file>
Note: This PR contains a large number of files. cubic only reviews up to 200 files per PR, so some files may not have been reviewed. cubic prioritizes the most important files to review.
Re-trigger cubic
| // language-agnostic; it is duplicated (not shared) to keep each generator | ||
| // fully decoupled and avoid modifying the already-shipped Crystal generator. | ||
| /** Pure routing logic for the Ruby-idiomatic generator: path -> (namespace, resource, action). */ | ||
| /** Pure routing logic for the ruby-nextgengenerator: path -> (namespace, resource, action). */ |
Contributor
There was a problem hiding this comment.
P3: The class-level Javadoc comment has a typo: ruby-nextgengenerator is missing a space. It should read ruby-nextgen generator to match the original comment's readability.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/rubynextgen/RubyApiRouting.java, line 10:
<comment>The class-level Javadoc comment has a typo: `ruby-nextgengenerator` is missing a space. It should read `ruby-nextgen generator` to match the original comment's readability.</comment>
<file context>
@@ -1,13 +1,13 @@
// language-agnostic; it is duplicated (not shared) to keep each generator
// fully decoupled and avoid modifying the already-shipped Crystal generator.
-/** Pure routing logic for the Ruby-idiomatic generator: path -> (namespace, resource, action). */
+/** Pure routing logic for the ruby-nextgengenerator: path -> (namespace, resource, action). */
public final class RubyApiRouting {
private RubyApiRouting() {}
</file context>
Suggested change
| /** Pure routing logic for the ruby-nextgengenerator: path -> (namespace, resource, action). */ | |
| /** Pure routing logic for the ruby-nextgen generator: path -> (namespace, resource, action). */ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a follow up pr to #24220
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Summary by cubic
Renamed the Ruby client generator from
ruby-idiomatictoruby-nextgenacross code, docs, tests, workflows, and samples. Use-g ruby-nextgenand theruby-nextgentemplates; no behavior changes.-g ruby-idiomaticwith-g ruby-nextgen.modules/openapi-generator/src/main/resources/ruby-nextgen.ruby-idiomatictoruby-nextgen.org.openapitools.codegen.languages.RubyNextgenClientCodegen.Written for commit 95f0c81. Summary will update on new commits.