Madhus1218 fix csharp generichost oneof serialization - #24735
Draft
wing328 wants to merge 6 commits into
Draft
Conversation
…github.com/madhus1218/openapi-generator into madhus1218-fix-csharp-generichost-oneof-serialization
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Summary by cubic
Fixes C#
generichostoneOf serialization when no discriminator. Old behavior wrapped everything in an object; new behavior serializes primitives/arrays as raw values and writes referenced model properties inline. This produces correct JSON; discriminator-based serialization is unchanged.modules/openapi-generator/src/main/resources/csharp/libraries/generichost/JsonConverter.mustacheadds early returns for primitive/array and other non-objectoneOfcases, and writes the selected referenced-model properties into the object before common properties. Samples were regenerated across all target frameworks to reflect the corrected output.generichostclients. Update consumers/tests that depended on object-wrapped JSON foroneOfprimitives, arrays/lists, or referenced models.Written for commit 33c9825. Summary will update on new commits.