Skip to content

[BUG][Java][Spring] Generated code fails Error Prone UnnecessaryFinal bug pattern - #24745

Open
anthonyvdotbe wants to merge 1 commit into
OpenAPITools:masterfrom
anthonyvdotbe:master
Open

[BUG][Java][Spring] Generated code fails Error Prone UnnecessaryFinal bug pattern#24745
anthonyvdotbe wants to merge 1 commit into
OpenAPITools:masterfrom
anthonyvdotbe:master

Conversation

@anthonyvdotbe

@anthonyvdotbe anthonyvdotbe commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Fixes #24744

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Remove redundant final modifiers from constructor parameters in generated Spring HTTP interface configurators. This eliminates Error Prone UnnecessaryFinal warnings without changing runtime behavior.

  • Update templates httpInterfacesConfiguration.mustache and httpServiceProxyFactoryInterfacesConfigurator.mustache in the JavaSpring spring-http-interface library.
  • Regenerate affected samples to reflect the change.
  • No migration required; output differs only by parameter modifiers and compiles the same.

Written for commit c7f14f8. Summary will update on new commits.

Review in cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 11 files

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][Java][Spring] Generated code fails Error Prone UnnecessaryFinal bug pattern

1 participant