fix(java-spring): add @Deprecated annotation to fluent setters for deprecated properties

[ANUSH2510]

Description

Fixes #24704

The @Deprecated annotation was correctly generated on getters and standard setters for properties marked deprecated: true, but was missing on the corresponding fluent setter methods — for both a class's own properties and properties inherited from a parent schema (including the array/map item-adder variants: addXxxItem, putXxxItem).

Changes

• Updated pojo.mustache to wrap all fluent setter variants (single, array-item, map-item; both own and inherited) with the same {{#deprecated}}@Deprecated{{/deprecated}} block already used for the standard setter.
• Added a regression test shouldGenerateDeprecatedAnnotationOnFluentSetter in SpringCodegenTest.
• Regenerated the affected sample (spring-cloud-deprecated) to reflect the fix.

Testing

• New test passes.
• Full SpringCodegenTest suite passes (328/328).
• Verified manually against a custom spec with allOf inheritance + deprecated: true.

---

Summary by cubic

Annotates all fluent setters for deprecated properties with @deprecated in the Java Spring generator, matching the existing getters and standard setters. Previously, fluent setters (including inherited and array/map item adders) lacked the annotation; now compilers/IDEs will warn when they are used.

• Updated JavaSpring/pojo.mustache to apply @deprecated to fluent setters for own and inherited properties, including addXxxItem and putXxxItem, when the property has deprecated: true.
• Added regression test shouldGenerateDeprecatedAnnotationOnFluentSetter and regenerated the spring-cloud-deprecated sample.
• Impact: Generated models may now emit deprecation warnings when calling fluent setters for deprecated fields. No runtime changes or configuration updates required.

^{Written for commit 12e4ce1. Summary will update on new commits.}

[wing328]

thanks for the PR

is this the same as #24705 ?

[cubic-dev-ai]

1 issue found across 3 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="modules/openapi-generator/src/test/java/org/openapitools/codegen/java/spring/SpringCodegenTest.java">

<violation number="1" location="modules/openapi-generator/src/test/java/org/openapitools/codegen/java/spring/SpringCodegenTest.java:5852">
P2: This regression test only covers the single fluent setter of the own enum property `status`. The fix claims to cover inherited-property fluent setters and the `addXxxItem`/`putXxxItem` variants, none of which this test exercises (Pet is not a child schema and `status` is not a container). Extend the test to cover those variants so a regression in the rest of the fix is detected.</violation>
</file>

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[cubic-dev-ai]

P2: This regression test only covers the single fluent setter of the own enum property status. The fix claims to cover inherited-property fluent setters and the addXxxItem/putXxxItem variants, none of which this test exercises (Pet is not a child schema and status is not a container). Extend the test to cover those variants so a regression in the rest of the fix is detected.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At modules/openapi-generator/src/test/java/org/openapitools/codegen/java/spring/SpringCodegenTest.java, line 5852:

<comment>This regression test only covers the single fluent setter of the own enum property `status`. The fix claims to cover inherited-property fluent setters and the `addXxxItem`/`putXxxItem` variants, none of which this test exercises (Pet is not a child schema and `status` is not a container). Extend the test to cover those variants so a regression in the rest of the fix is detected.</comment>

<file context>
@@ -5833,6 +5833,24 @@ public void shouldGenerateSingleDeprecatedAnnotation() {
+        new DefaultGenerator().opts(configurator.toClientOptInput()).generate();
+
+        JavaFileAssert.assertThat(tempDir.resolve("src/main/java/org/openapitools/model/Pet.java"))
+                .assertMethod("status", "StatusEnum").hasAnnotation("Deprecated");
+    }
 
</file context>