Skip to content

cpp-httplib-server: add inline to methods, better code indentation - #25251

Merged
wing328 merged 1 commit into
masterfrom
25225-followup
Oct 14, 2026
Merged

wing328 merged 1 commit into
masterfrom
25225-followup

Conversation

@wing328

@wing328 wing328 commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

a follow up pr to #25225

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Adds inline to the to_json and from_json friend functions in the cpp-httplib-server model header template and fixes the indentation of their bodies. Regenerates the affected petstore samples.

Written for commit c261130. Summary will update on new commits.

View guided diff Turn on auto-fix

@wing328 wing328 changed the title add inline, better code indentation cpp-httplib-server: add inline to methods, better code indentation Oct 14, 2026
@wing328 wing328 added this to the 7.27.0 milestone Oct 14, 2026
@wing328
wing328 marked this pull request as ready for review October 14, 2026 03:24

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 38 files

View guided diff | Turn on auto-fix | Re-trigger cubic

@wing328
wing328 merged commit e95a103 into master Oct 14, 2026
27 checks passed
@wing328
wing328 deleted the 25225-followup branch October 14, 2026 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants