Skip to content

Add tests for jdk 25 in the github workflow - #25440

Open
dijkstrar wants to merge 6 commits into
OpenAPITools:masterfrom
dijkstrar:add-jdk-25-tests-gh-workflow
Open

dijkstrar wants to merge 6 commits into
OpenAPITools:masterfrom
dijkstrar:add-jdk-25-tests-gh-workflow

Conversation

@dijkstrar

@dijkstrar dijkstrar commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Adds JDK 25 to the Linux and Windows GitHub Actions CI test matrices and bumps Gradle to 9.1.0 and JaCoCo to 0.8.14, both required for JDK 25 support.

  • JDK 25 is now tested on ubuntu-latest and windows-latest alongside JDK 11 and 17.
  • Updates the Gradle test version to 9.1.0 and the JaCoCo version to 0.8.14.

Potential issue

  • pom.xml now defines jackson.version and jackson-annotations.version twice with conflicting values (2.21.4/2.21 and 2.21.8/2.22); the later definitions win, but the duplicates should be cleaned up.

Written for commit bd36c93. Summary will update on new commits.

View guided diff

@dijkstrar

Copy link
Copy Markdown
Contributor Author

JDK 25 is the latest LTS jdk, so i want to add support for it :)
https://www.oracle.com/java/technologies/downloads/

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed

Reply with feedback, questions, or to request a fix.

View guided diff | Re-trigger cubic

Comment thread .github/workflows/windows.yaml Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed

Reply with feedback, questions, or to request a fix.

View guided diff | Re-trigger cubic

Comment thread .github/workflows/linux.yaml Resolved
@dijkstrar

dijkstrar commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor Author

@wing328 can you have a look at this? JDK25 is LTS :)

Edit: i see some tasks are failing, will look into it :)

@dijkstrar

Copy link
Copy Markdown
Contributor Author

There is a version compatability, in guess what, Kotlin ;)

This build will succeed once #25246 gets merged ;)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant