[wing328]

disable the test due to the following errors:

[ERROR] Failures:
[ERROR] org.openapitools.codegen.python.PythonFlaskConnexionServerCodegenTest.testControllerTestModelExampleUsesImportedName
[ERROR]   Run 1: PythonFlaskConnexionServerCodegenTest.testControllerTestModelExampleUsesImportedName:176 File 'C:\Users\User\AppData\Local\Temp\test9469312943545207622\openapi_server\test\test_default_controller.py' does not contain line [query_string = [('filter', Filter()),] expected [true] but found [false]
[ERROR]   Run 2: PythonFlaskConnexionServerCodegenTest.testControllerTestModelExampleUsesImportedName:176 File 'C:\Users\User\AppData\Local\Temp\test13514954729255540111\openapi_server\test\test_default_controller.py' does not contain line [query_string = [('filter', Filter()),] expected [true] but found [false]
[ERROR]   Run 3: PythonFlaskConnexionServerCodegenTest.testControllerTestModelExampleUsesImportedName:176 File 'C:\Users\User\AppData\Local\Temp\test10574054070658084280\openapi_server\test\test_default_controller.py' does not contain line [query_string = [('filter', Filter()),] expected [true] but found [false]

@khayashi4337, when you've time, can you please revise the test and re-enable it?

PR checklist

• Read the contribution guidelines.
• Run the following to build the project and update samples:

  ./mvnw clean package || exit
  ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
  ./bin/utils/export_docs_generators.sh || exit
  

  (For Windows users, please run the script in WSL)
  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

---

Summary by cubic

Disables the testControllerTestModelExampleUsesImportedName test in the Python Flask generator so it stops failing in CI.

^{Written for commit 6f55df9. Summary will update on new commits.}

[cubic-dev-ai]

1 issue found across 1 file

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="modules/openapi-generator/src/test/java/org/openapitools/codegen/python/PythonFlaskConnexionServerCodegenTest.java">

<violation number="1" location="modules/openapi-generator/src/test/java/org/openapitools/codegen/python/PythonFlaskConnexionServerCodegenTest.java:168">
P2: This disables the only regression test that verifies model examples use the imported `Filter`/`Trace` classes; the test documents that `openapi_server.Filter()` raises `NameError`. Re-enable it and fix the generator output rather than masking the failure.</violation>
</file>

<sub>Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic</sub>

[cubic-dev-ai]

P2: This disables the only regression test that verifies model examples use the imported Filter/Trace classes; the test documents that openapi_server.Filter() raises NameError. Re-enable it and fix the generator output rather than masking the failure.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At modules/openapi-generator/src/test/java/org/openapitools/codegen/python/PythonFlaskConnexionServerCodegenTest.java, line 168:

<comment>This disables the only regression test that verifies model examples use the imported `Filter`/`Trace` classes; the test documents that `openapi_server.Filter()` raises `NameError`. Re-enable it and fix the generator output rather than masking the failure.</comment>

<file context>
@@ -165,7 +165,7 @@ public void testDefaultController() throws IOException {
     }
 
-    @Test(description = "model examples in generated controller tests use the imported class name, not the package")
+    @Test(description = "model examples in generated controller tests use the imported class name, not the package", enabled = false)
     public void testControllerTestModelExampleUsesImportedName() throws IOException {
         final DefaultCodegen codegen = new PythonFlaskConnexionServerCodegen();
</file context>

Suggested change

	@Test(description = "model examples in generated controller tests use the imported class name, not the package", enabled = false)
	@Test(description = "model examples in generated controller tests use the imported class name, not the package")

[khayashi4337]

Thanks for disabling it, and sorry for the breakage on master. #25426 and #25485 were merged within a day of each other and the controller-test query rendering changed in between, so the assertion in this test went stale. I'll check what master generates now, fix the assertion, and send a PR that re-enables it.

[khayashi4337]

Opened #25552 to fix the stale assertion and re-enable the test.