Repository navigation
fix(java): serialize Feign Jackson JSON headers - #25530
Open
AndreyVMarkelov wants to merge 2 commits into
Open
AndreyVMarkelov wants to merge 2 commits into
AndreyVMarkelov wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 9 files
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Serialize JSON-content header parameters in Java Feign/Jackson clients as JSON instead of the model's
toString()value. This extends the behavior addressed for okhttp-gson in #25056 to Feign/Jackson.The generated client uses its configured Jackson mapper, escapes non-ASCII header characters, and leaves ordinary headers on the existing path. Configure the default mapper to omit optional null properties, consistent with the shared Java client mapper. Update affected Feign samples.
Tests
JavaClientCodegenTest#testFeignJacksonJsonHeader.--library feign --additional-properties=serializationLibrary=jackson; verified a generated download request's JSON header using a local transport.The generated-client runtime fixture was copied into the generated client's test directory and run with Maven.
PR checklist
Summary by cubic
Serializes JSON-content header parameters in generated Java Feign/Jackson clients as JSON instead of the model's
toString()value, matching existing okhttp-gson behavior.ApiClient.JsonHeaderParamExpanderwith a custom Feign contract and array proxy so JSON headers, including arrays, serialize with the client's configured Jackson mapper and escape non-ASCII characters.NON_NULLinclusion only to header serialization; request-body serialization keeps nulls.Migration
Generated Feign/Jackson clients now output JSON for headers declared with
application/jsoncontent — callers expectingtoString()output must validate their header formats.Written for commit e66f5fa. Summary will update on new commits.