Repository navigation
fix(java): serialize primitive arrays in Gson oneOf - #25542
Open
AndreyVMarkelov wants to merge 1 commit into
Open
AndreyVMarkelov wants to merge 1 commit into
AndreyVMarkelov wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #25541
Fix Java
okhttp-gsonserialization of aoneOfcontaining an array of primitive strings. The generated adapter now writes the array as aJsonArrayinstead of trying to convert it to aJsonPrimitive.This reproduces on master independently of #25539. Empty array values have a separate existing limitation in
setActualInstanceand are outside this change.Tests
okhttp-gson-oneOf-arraysample tests: 3 passed, 1 skipped.Summary by cubic
Fixes #25541: Java
okhttp-gsongeneration previously serialized aoneOfcontaining a primitive string array by callinggetAsJsonPrimitive()on the array's JSON tree, which threw an exception. The generated adapter now writes the array as aJsonArray, so the schema round-trips correctly.oneof_model.mustachetemplate to handle array types separately from other primitives.okhttp-gsonsamples.setActualInstanceand are not addressed here.Written for commit c5cb902. Summary will update on new commits.