Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 7.13.0 (#20816)
basePathfield inapi.base.service.tsis rendered from supporting files bundleDefaultGeneratorcopies additional properties into that bundle first and then puts server URL asbasePathon top, so--additional-properties=basePath=(or<additionalProperties>basePath=</additionalProperties>in maven plugin) is ignored and client always gets server URL from specOverride worked up to 7.11.0 while field lived in
api.service.ts, api templates get additional properties lastNow
TypeScriptAngularClientCodegenputs user suppliedbasePathback inpostProcessSupportingFileData, without it bundle stays as isFix is kept in angular generator, reordering in
DefaultGeneratorwould change supporting files of every generator that readsbasePathAdded
testBasePathFromAdditionalPropertiesnext totestBasePath, it generates withbasePathset to''and/apiand checks field inapi.base.service.ts, it fails on masterSample configs dont set
basePath, regenerated typescript-angular samples have no diffFixes #21438
Open #25353 adds
postProcessSupportingFileDatato same class too, whichever lands second needs to merge both into one overridePR checklist
@mentionthe technical committee members, so they are more likely to review the pull request.@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov @davidgamero @mkusaka @joscha @KannaKim
Summary by cubic
Restores the
basePathoverride from additional properties in thetypescript-angulargenerator, which has been ignored since 7.13.0. The generated client now honors a user-suppliedbasePathinstead of always falling back to the server URL from the spec.postProcessSupportingFileDatainTypeScriptAngularClientCodegen; the fix is scoped to the angular generator so other generators that readbasePathare unaffected.basePathset to''and/api.Written for commit ce7f728. Summary will update on new commits.