Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typescript-angular generates
Set<T>foruniqueItemsarrays, but json query params (content: application/jsonorqueryParamObjectFormat=json) go through bareJSON.stringifyinaddToHttpParams, andJSON.stringify(new Set(['a', 'b']))is{}, so request goes out withtags={}. #23442 fixed only the form branchJson branch now uses a replacer that turns
Setinto an array, other values serialize byte for byte as before. AddeduniqueItemstagsparam to3_0/query-param-json.yamland a Karma case toapi.query_param_json.spec.tsin typescript-angular-v20 sample, it fails on master withtags=%7B%7Dand passes with the fixRan
./bin/generate-samples.sh bin/configs/typescript-angular*.yaml, onlyapi.base.service.tschanges by one line in each sample, plus the new param inquery-param-json../mvnw clean packagepasses except Kotlin generator tests, those fail on JDK 25 on my machine (embeded Kotlin compiler)Fixes #13500
PR checklist
@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov @davidgamero @mkusaka @joscha @KannaKim
Summary by cubic
Fixes serialization of
Setquery parameters in typescript-angular so JSON-style query params are sent as arrays instead of{}.JSON.stringifynow uses a replacer that convertsSetinstances to arrays; all other values serialize unchanged. Fixes #13500.Written for commit 77f6291. Summary will update on new commits.