fix: remove dead config module with undeclared pydantic_settings import#1021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openadapt/config.py is referenced by nothing (only its own docstring). Importing it raises ModuleNotFoundError: the launcher deliberately trimmed its dependencies to click + openadapt-flow in #1013/#1014 and pydantic_settings is not declared. Surfaced while triaging (now-closed) #1005.
Removing the module is safer than declaring the dependency: the settings it defines (API keys, capture dirs, model settings) belong to the pre-compiler training era, not the launcher. 31 tests + 1 skip pass locally.
🤖 Generated with Claude Code