docs(readme): fix Resolution ladder text overflow in masthead SVG#1042
Merged
Conversation
The Resolution ladder box was the only box using multi-line body text, and those lines started at y+68 instead of the y+50 baseline used by every sibling box's subtitle. That produced a 38px heading-to-body gap (vs 20px elsewhere) and pushed the third line to y=394, past the box bottom at y=388, so the text overflowed. Start the ladder body lines at y+50 like the other boxes: the three lines now sit at y=346/361/376, matching the sibling gap and fitting inside the 92px box with the same internal padding. Only those three text baselines change; all other boxes were already consistent and their body text sits within bounds. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NyCHrzA1psrKMFfroYbzaM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1041. The "Resolution ladder" box in
media/openadapt-hero.svghad a larger gap between its heading and its body text than the sibling boxes, and the third line overflowed the box.Cause: the ladder box is the only box with multi-line body text, and those lines started at
y+68instead of they+50baseline every sibling box's subtitle uses. That gave a 38px heading-to-body gap (vs 20px elsewhere) and placed the third line aty=394, past the box bottom aty=388.Fix: start the ladder body lines at
y+50like the other boxes. The three lines now sit aty=346 / 361 / 376, matching the sibling heading-to-body gap and fitting inside the 92px box with the same internal padding. The diff is exactly those three text baselines; nothing else changes.Checked while in there: the ladder is the only multi-line box; all other boxes already use the consistent
y+30title /y+50subtitle spacing, and every box's body text sits within its bounds at the rendered size (verified in both light and dark re-renders).Re-rendered light + dark for review. README/SVG only, no em dashes.