Repository navigation
SignPath: match the MSI's program files under its install directory - #1736
Merged
Merged
Conversation
The test-signing request 7fa928cb (run 41576282781) failed. Inside the MSI, openadapt-desktop.exe and openadapt-engine.exe sit under PFiles/OpenAdapt Desktop/, and the pe-file-set included "*.exe", which does not cross a directory separator and so matched nothing (min-matches defaults to 1). Use "**/*.exe" and "**/*.dll", and test that every include is recursive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The SignPath test-signing request
7fa928cbfrom run 41576282781 failed about 30 seconds after it was submitted:The submission was accepted, so the project slug, policy slug and origin checks passed. The request failed while SignPath was processing the package.
The unsigned artifact from that run shows the cause. In the MSI, both PE files are under the install directory, not the root:
INSTALLDIR(OpenAdapt Desktop)ProgramFiles64Folder(PFiles)openadapt-desktop.exe,openadapt-engine.exeThe artifact configuration's
pe-file-setincluded*.exe. In SignPath,*does not match a directory separator, andmin-matchesdefaults to 1, so the set matched nothing and the request failed.Change
.signpath/artifact-configurations/openadapt-desktop-installers.xml: the includes are now**/*.exeand**/*.dll.tests/test_native_signing.py: checks that every include in the MSI's PE file set is recursive.After merge (SignPath web UI, founder)
SignPath doesn't read this file from the repository. To apply the fix:
main. The policy refuses re-runs, so don't re-run the old one.If the new request also fails, the reason is on the request's page in SignPath (the GitHub log doesn't include it).