Repository navigation
Covered band: the dismiss step's dialog box is the proved covering window - #1759
Merged
Merged
Conversation
Member
Author
|
Independent adversarial review: approved in round 2, no blockers. Round 1 blocked the PR because its own new test failed: the test's OCR lines had no Round 2 findings:
Non-blockers for a follow-up:
Tests: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found on the live Windows lab run, after #1735, #1739 and #1740. The Patient Notes "Session notice" stop was reclassified as a covered band, and the scripted "OK" click passed the #1740 dismiss guard: the same window, and text that reads as a session notice. The patch then refused it: "no dialog was found around the click".
A new click admitted on the record check carries the dialog around it as its identity band. Until now that box came from two places:
dialogrole, orThe Windows MessageBox matched neither.
The change.
_dialog_bandtakes aproved_region. In covered-band mode,_new_clickpasses the region of the window thatowned_window_overproved covers the band. That is the same window the click was already required to land in. The proved region is used before the ancestry and pixel search. The click must still lie inside it.Outside covered-band mode nothing changes. In covered mode, a cover without a
regionwas already refused earlier, by_cover_explains_cut, so there is no path without a proved window.Evidence. The live run's result and README finding 10 are on
claude/repair-windows-qualify(results/windows-uia-20261103-no-dialog-box.json). Nothing was written and the stop came before any save.Tests. A new test shows a blank screen refused without a proved region, the proved box used when given, and a click outside the box refused.