Verifier: no app's endpoints, layout or record ids as engine defaults

packages/agent/tests/test_approval_flow.py

@@ -91,6 +91,8 @@ def _bridge(
             "web",
             "--effects-kind",
             "rest",
+            "--effects-records-path",
+            "/api/db",
             "--effects-base-url",
             mockmed["base_url"],
         ),

packages/desktop/tests/test_engine/test_check_setup.py

@@ -279,7 +279,9 @@ def test_fixed_values_are_the_recorded_ones_and_follow_the_sealed_version(tmp_pa
     with pytest.raises(CheckSetupError, match="Unknown value"):
         answer_values(dispatcher, "wf1", ["member_id"], answered_by="person")
 
-    store.write_record_check_config("wf1", {"kind": "rest", "base_url": BASE})
+    store.write_record_check_config(
+        "wf1", {"kind": "rest", "records_path": "/api/db", "base_url": BASE}
+    )
     saved = store.load("wf1")
     saved["record_check_config"] = str(store.root / "wf1.record-check.yaml")
     store.save("wf1", saved)

packages/flow/CHANGELOG.md

@@ -43,6 +43,10 @@
 
 ### Fixes
 
+- A REST read names its own records path: `effects.kind: rest`, a reward recipe of kind `rest`, `RestRecordVerifier`, `RestCompensator` and the fault gate's in-memory copy require `records_path` (and `records_key`, `delete_path_template`) instead of defaulting to the demo app's `/api/db`; `run --effects-kind rest` takes `--effects-records-path`. Compile-time REST binding admission (`compile_recording(admit_api_bindings=True, admission_fixture=...)`) takes the app's read path, write path, server-assigned fields and idempotency key field from an `AdmissionFixture`, and proposes nothing when no write was captured and no write path is named. Effect mining and `scaffold-verifier` mine an idempotency key only from a field the caller names. Verifier identities and fault-gate check digests of existing configs are unchanged.
+
+- A FHIR read names its resource and field map: `effects.kind: fhir`, a reward recipe of kind `fhir` and `FhirEffectVerifier` require `resource_type` and `field_paths` instead of defaulting to one app's note-as-Observation layout (`DEFAULT_OBSERVATION_PATHS` stays importable for callers whose app stores notes that way). An app profile's `no_record_values` lists the record-field values its audit entries use for "no record" (OpenEMR's profile: `"0"`; profile version `openemr-frame-profile/2026-11-03.1`, so a config that pins the old profile digest is refused until it pins the new one); the frame and rollback no longer treat `0` as "no record" in every app. `generate ensure-contract` reads only the generic server-fact names from `facts.json`; the Medplum probe's translation moved to `benchmark/fhir_medplum/readpath/facts.py`.
+
 - A qualification case can run on `--backend windows`. `WindowsBackend` now answers the qualification environment observer from one `/context/identity` call: the foreground executable's name, the SHA-256 of that executable file, the live logon-session digest, and a digest of the machine id and exact OS build. Before, `qualify run-case` on Windows refused with "qualification backend cannot observe the complete environment". The digest is withheld when the file changed after the process started (an updater replacing a running program), and it describes the host executable for an app run by an interpreter, browser or shared runtime. Guarded input now also binds the digest and the environment, so a same-named program from another path cannot take the foreground between the check and the input. The agent's session digest now accepts a connected RDP or Citrix session, not only the console session, so the agent can run inside a remote user session. An agent without the new `context_environment_v1` fields still refuses ([#1696](https://github.com/OpenAdaptAI/OpenAdapt/issues/1696)).
 
 - A covered-band dismiss step takes its dialog box from the window the backend proved covers the band, before any pixel search, so a native message box that the accessibility tree doesn't label as a dialog can be dismissed. Without a proved window the step is refused as before.

packages/flow/benchmark/contract_autogen/blind.py

@@ -25,14 +25,14 @@
 import hashlib
 import json
 import os
-import shutil
 import sys
 import time
 from pathlib import Path
 from typing import Any, Optional
 
 from benchmark.fhir_medplum.fixture import FixtureError, MedplumFixture, _http
 from benchmark.fhir_medplum.readpath import suite as runner
+from benchmark.fhir_medplum.readpath.facts import generic_facts
 
 HERE = Path(__file__).resolve().parent
 PROBE = HERE.parent / "fhir_medplum" / "readpath" / "probe.json"
@@ -101,7 +101,7 @@ def cmd_teach(args: argparse.Namespace) -> int:
         out / "search_parameters.json",
         read_all(f"{fx.fhir_url}/SearchParameter?base={rtype}&_count=200", reader),
     )
-    shutil.copyfile(PROBE, out / "facts.json")
+    _dump(out / "facts.json", generic_facts(json.loads(PROBE.read_text())))
     _dump(
         out / "teach.json",
         {

packages/flow/benchmark/contract_autogen/build_patient_teach.py

@@ -18,6 +18,7 @@
 
 import json
 from pathlib import Path
+from benchmark.fhir_medplum.readpath.facts import generic_facts
 
 HERE = Path(__file__).resolve().parent
 SRC = HERE.parent / "fhir_medplum" / "readpath"
@@ -123,7 +124,14 @@ def main() -> None:
     (OUT / "search_parameters.json").write_text(
         json.dumps(params_bundle, indent=1) + "\n"
     )
-    (OUT / "facts.json").write_text((SRC / "probe.json").read_text())
+    (OUT / "facts.json").write_text(
+        json.dumps(
+            generic_facts(json.loads((SRC / "probe.json").read_text())),
+            indent=2,
+            sort_keys=True,
+        )
+        + "\n"
+    )
     teach = {
         "resource_type": "Patient",
         "deployment": {

packages/flow/benchmark/contract_autogen/teach/immunization/facts.json

@@ -1,87 +1,8 @@
 {
-  "audit_lag_s": {
-    "C": {
-      "max": 0.043,
-      "median": 0.036
-    },
-    "D": {
-      "max": 0.049,
-      "median": 0.036
-    },
-    "U": {
-      "max": 0.043,
-      "median": 0.031
-    }
-  },
-  "audit_names_the_user_profile": true,
-  "audit_seen_on_an_immediate_read": [
-    "C by bot",
-    "C by bot",
-    "D by bot",
-    "U by other"
-  ],
-  "audit_writes_are_logged": false,
-  "bot_admin_endpoint": "HTTP 403",
-  "bot_is_project_admin": false,
-  "bot_is_super_admin": false,
-  "bundle_and_graphql_writes_logged": [
-    "C Observation by bot",
-    "C Observation by bot",
-    "C Patient by bot",
-    "C Patient by bot",
-    "C Patient by bot",
-    "C Patient by bot",
-    "C Patient by bot",
-    "C Patient by bot",
-    "C Patient by bot",
-    "C Patient by bot",
-    "C Patient by bot",
-    "C Patient by bot",
-    "C Patient by bot",
-    "C Patient by bot",
-    "C Patient by bot",
-    "D Patient by bot",
-    "D Patient by bot",
-    "D Patient by bot",
-    "D Patient by bot",
-    "D Patient by bot",
-    "D Patient by bot",
-    "D Patient by bot",
-    "D Patient by bot",
-    "D Patient by bot",
-    "D Patient by bot",
-    "D Patient by bot",
-    "U Patient by bot",
-    "U Patient by bot",
-    "U Patient by bot",
-    "U Patient by bot",
-    "U Patient by bot",
-    "U Patient by bot",
-    "U Patient by bot",
-    "U Patient by bot",
-    "U Patient by bot",
-    "U Patient by bot"
-  ],
-  "date_header": true,
-  "delete_in_history": true,
-  "meta_author_returned": false,
-  "policy": "AccessPolicy/f348be14-df4d-47cc-a49b-1f45e08dd554",
-  "restricted_bot_audit_read_only": true,
-  "restricted_bot_audit_writes": {
-    "create": "HTTP 403",
-    "delete": "HTTP 403",
-    "update": "HTTP 403"
-  },
-  "restricted_bot_can_write": {
-    "Observation": "allowed",
-    "Patient": "allowed",
-    "Task": "allowed"
-  },
-  "sweep_sees_delete": false,
-  "type_history": "HTTP 404",
-  "unrestricted_bot_audit_writes": {
-    "create": null,
-    "delete": null,
-    "update": null
-  }
+  "agent_cannot_write_audit": true,
+  "audit_lag_max_s": 0.049,
+  "audit_logs_writes": true,
+  "audit_names_actor": true,
+  "history_lists_versions": true,
+  "meta_author_returned": false
 }

packages/flow/benchmark/contract_autogen/teach/medplum_patient_rebuilt/facts.json

@@ -1,87 +1,8 @@
 {
-  "audit_lag_s": {
-    "C": {
-      "max": 0.043,
-      "median": 0.036
-    },
-    "D": {
-      "max": 0.049,
-      "median": 0.036
-    },
-    "U": {
-      "max": 0.043,
-      "median": 0.031
-    }
-  },
-  "audit_names_the_user_profile": true,
-  "audit_seen_on_an_immediate_read": [
-    "C by bot",
-    "C by bot",
-    "D by bot",
-    "U by other"
-  ],
-  "audit_writes_are_logged": false,
-  "bot_admin_endpoint": "HTTP 403",
-  "bot_is_project_admin": false,
-  "bot_is_super_admin": false,
-  "bundle_and_graphql_writes_logged": [
-    "C Observation by bot",
-    "C Observation by bot",
-    "C Patient by bot",
-    "C Patient by bot",
-    "C Patient by bot",
-    "C Patient by bot",
-    "C Patient by bot",
-    "C Patient by bot",
-    "C Patient by bot",
-    "C Patient by bot",
-    "C Patient by bot",
-    "C Patient by bot",
-    "C Patient by bot",
-    "C Patient by bot",
-    "C Patient by bot",
-    "D Patient by bot",
-    "D Patient by bot",
-    "D Patient by bot",
-    "D Patient by bot",
-    "D Patient by bot",
-    "D Patient by bot",
-    "D Patient by bot",
-    "D Patient by bot",
-    "D Patient by bot",
-    "D Patient by bot",
-    "D Patient by bot",
-    "U Patient by bot",
-    "U Patient by bot",
-    "U Patient by bot",
-    "U Patient by bot",
-    "U Patient by bot",
-    "U Patient by bot",
-    "U Patient by bot",
-    "U Patient by bot",
-    "U Patient by bot",
-    "U Patient by bot"
-  ],
-  "date_header": true,
-  "delete_in_history": true,
-  "meta_author_returned": false,
-  "policy": "AccessPolicy/f348be14-df4d-47cc-a49b-1f45e08dd554",
-  "restricted_bot_audit_read_only": true,
-  "restricted_bot_audit_writes": {
-    "create": "HTTP 403",
-    "delete": "HTTP 403",
-    "update": "HTTP 403"
-  },
-  "restricted_bot_can_write": {
-    "Observation": "allowed",
-    "Patient": "allowed",
-    "Task": "allowed"
-  },
-  "sweep_sees_delete": false,
-  "type_history": "HTTP 404",
-  "unrestricted_bot_audit_writes": {
-    "create": null,
-    "delete": null,
-    "update": null
-  }
+  "agent_cannot_write_audit": true,
+  "audit_lag_max_s": 0.049,
+  "audit_logs_writes": true,
+  "audit_names_actor": true,
+  "history_lists_versions": true,
+  "meta_author_returned": false
 }

packages/flow/benchmark/fhir_medplum/readpath/facts.py

@@ -0,0 +1,47 @@
+"""Translate this probe's output into the generic server facts.
+
+``openadapt_flow.generate.ensure_contract`` reads only the generic names in
+``FACTS`` from a teach directory's ``facts.json``; what each Medplum probe
+measured, and under which name, stays here with the probe.
+
+    PYTHONPATH=. python -m benchmark.fhir_medplum.readpath.facts probe.json > facts.json
+"""
+
+from __future__ import annotations
+
+import json
+import sys
+from typing import Any, Mapping
+
+from openadapt_flow.generate.ensure_contract import FACTS
+
+
+def generic_facts(probe: Mapping[str, Any]) -> dict[str, Any]:
+    """The generic facts this probe's output supports, by their generic names."""
+
+    if all(k in probe for k in FACTS):
+        return {k: probe[k] for k in FACTS}
+    out: dict[str, Any] = {}
+    logged = probe.get("bundle_and_graphql_writes_logged")
+    if isinstance(logged, list):
+        out["audit_logs_writes"] = len(logged) > 0
+    for name, key in (
+        ("audit_names_actor", "audit_names_the_user_profile"),
+        ("agent_cannot_write_audit", "restricted_bot_audit_read_only"),
+        ("history_lists_versions", "delete_in_history"),
+        ("meta_author_returned", "meta_author_returned"),
+    ):
+        if key in probe:
+            out[name] = probe[key]
+    lags = probe.get("audit_lag_s")
+    if isinstance(lags, Mapping) and lags:
+        out["audit_lag_max_s"] = max(
+            float(v.get("max", 0)) for v in lags.values() if isinstance(v, Mapping)
+        )
+    return out
+
+
+if __name__ == "__main__":
+    with open(sys.argv[1], encoding="utf-8") as f:
+        json.dump(generic_facts(json.load(f)), sys.stdout, indent=2, sort_keys=True)
+    sys.stdout.write("\n")