Repository navigation
Conversation
Moved out of #1834. Needs Ledger.rechecks_owed from openadapt-flow, so it waits for the next flow release.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1670
Moved out of #1834 so that PR is flow-only. This draft waits for the next openadapt-flow release: it calls
Ledger.rechecks_owed, which the released openadapt-flow 2.5.0 (pinned in the lock) doesn't have, so the launcher job fails with AttributeError until a flow release that includes #1834 is in the lock.What changed
openadapt verify ledger listnow also shows each provisional CONFIRMED whose recheck is still owed, asrecheck-owedwith its due time and actor. A recheck isn't lost when the server that holds it restarts. When nothing is held, open or owed, it prints "No held or open writes. No rechecks owed."The two files are byte-identical to their versions at #1834 head 8559a6b, which Codex approved.
How it was tested
Not covered