OpenConceptLab/ocl_issues#2868 | Mapper splash leads with SNOMED GPS, ICD-10, LOINC and CIEL - #88
Merged
Merged
Conversation
…ED GPS, ICD-10, LOINC and CIEL Headline in en, es and zh. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
paynejd
commented
Oct 1, 2026
Member
Author
There was a problem hiding this comment.
Codex adversarial review, pass 1 (codex-cli 0.159.3, commit ae35b4e)
No findings.
Reviewed git diff origin/main...HEAD and checked surrounding app copy:
- All three locales name SNOMED GPS, ICD-10, LOINC and CIEL, in that order, and preserve the AI first-pass meaning. Spanish and Chinese read naturally.
- All three translation files parse as valid JSON;
git diff --checkpasses. - No component or test retains the old headline.
WaitListing.jsx:85uses the translation key directly. - No contradictory marketing copy appears in the splash, its image,
public/index.html, or app title/metadata code. Remaining ICD-11 references describe server configuration, implementation details, or test fixtures.
No files changed.
…stom terminology" Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
paynejd
commented
Oct 1, 2026
paynejd
left a comment
Member
Author
There was a problem hiding this comment.
Codex adversarial review, pass 2 (codex-cli 0.159.3, commit b8c1e8a)
No concrete findings in git diff origin/main...HEAD.
- All three locales convey the same meaning and read naturally.
- All three JSON files parse successfully.
- The headline in
WaitListing.jsx:73wraps normally, uses responsive font sizing, and has a 980px maximum width without truncation.
Layout assessment was source-only; browser rendering was not performed. The parent’s fixed height and hidden overflow remain an existing constraint on short screens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes OpenConceptLab/ocl_issues#2868
The preview splash headline now leads with SNOMED GPS, ICD-10, LOINC and CIEL, and mentions custom terminologies:
Updated in en, es and zh (
preview_splash_headline). No other strings change.Checked: CI's ESLint command passes; all three translation files parse as JSON. Codex passes 1 and 2 are clean.
🤖 Generated with Claude Code