OpenConceptLab/ocl_online#299 | Banner: subscription dates (Nov 1 / Dec 1 grace period), "Learn more" and "See pricing" - #89
Merged
Conversation
…ec 1 grace period), "Learn more" and "See pricing" New announcement id, so visitors who dismissed the preview banner see this one. Two links instead of one, each kept on one line on narrow screens: "Learn more" (the letter to the OCL community) and "See pricing" (new announcement.pricing_link_label in en/es/zh). Both carry utm_campaign=subscription_dates. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019j2N6BFoNmA32L2DHKZV41
paynejd
commented
Oct 1, 2026
paynejd
left a comment
Member
Author
There was a problem hiding this comment.
Codex adversarial review, pass 1 (codex-cli 0.159.2, commit 92c2a08)
Read-only. Posted verbatim. The destination pages it couldn't reach from its sandbox return 200 (checked after today's openconceptlab.org deploy).
Clean—no actionable findings.
- Unique, stable React keys; both links render in order with single-line labels.
- New announcement ID correctly resets dismissal; dismissing persists the new ID.
- Links remain keyboard accessible and use
target="_blank"withrel="noopener noreferrer". - Spanish and Chinese accurately convey the dates and grace period.
- URLs and UTM tags match the requested destinations and app attribution.
- JSON parsing, JSX/JS syntax checks, and
git diff --checkpassed. No stale constant references found.
Live destination verification was blocked by fetch/DNS failures. Full build and browser checks weren’t run. No files modified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Refs OpenConceptLab/ocl_online#299
Summary
Replaces the Mapper's public-preview announcement with the subscription-dates banner that is going live on openconceptlab.org, so the apps and the site say the same thing.
subscription-dates-2026-10(the same id as the community site), so visitors who dismissed the preview banner see this one.announcement.link_label, unchanged)announcement.pricing_link_labelin en/es/zh)utm_source=oclmap&utm_medium=banner&utm_campaign=subscription_dates.MAPPER_ANNOUNCEMENT_URLinsrc/common/constants.jsbecomesMAPPER_ANNOUNCEMENT_LETTER_URLandMAPPER_ANNOUNCEMENT_PRICING_URL.whiteSpace: 'nowrap', so a label doesn't break mid-label when the banner wraps on narrow screens.The banner doesn't record GA events today, and this PR doesn't add any.
Test Plan
./node_modules/eslint/bin/eslint.js src --ext .jsx,.js: cleannpm run test:all: 401 unit + 6 integration tests pass (no existing banner test; the suite runs.test.jsundernode --test, which doesn't cover JSX components)announcement.*has the same keys in en/es/zhNotes
Don't merge until Jon's go; production deploy is manual.
🤖 Generated with Claude Code
https://claude.ai/code/session_019j2N6BFoNmA32L2DHKZV41