OpenConceptLab/ocl_issues#2838 | Pull requests run the Eslint job, and npm run eslint lints .jsx - #57
Merged
Merged
Conversation
…d npm run eslint lints .jsx Lint ran only in build.yml, on pushes to main, so a pull request showed no lint result before it merged. - .github/workflows/pr.yml runs build.yml's Eslint job steps unchanged on every pull_request (read-only token; a newer push cancels the older run). build.yml is untouched. - package.json's eslint script adds --ext .jsx,.js; without it ESLint 8 lints only .js files, so npm run eslint skipped every .jsx. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lkm1wDY1zKSDTm2apzPJLi
paynejd
commented
Sep 28, 2026
paynejd
left a comment
Member
Author
There was a problem hiding this comment.
Codex adversarial review, pass 1 (codex-cli 0.158, commit 0533942)
Scope: origin/main...HEAD, including build.yml and the new pr.yml. Read-only run. The report below is verbatim.
Outcome: Clean.
No real issues found. The lint jobs are structurally identical, both YAML files parse, and build.yml is unchanged. Repository searches found no callers broken by the eslint script change. No files were modified.
This was referenced Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of OpenConceptLab/ocl_issues#2838 (oclweb3). The same change as OpenConceptLab/oclmap#84.
Summary
Lint ran only in
build.yml, on pushes tomain, so a pull request showed no lint result before it merged. A lint failure surfaced only after the merge, where it blocks the build and deploy.Change
.github/workflows/pr.yml(new): runsbuild.yml's "Eslint" job steps, unchanged, on everypull_request:start-prod.shsecret checknpm ci./node_modules/eslint/bin/eslint.js --ext .jsx,.js src/It has a read-only token, and a newer push to the same PR cancels the older run.
build.ymlis untouched, deploy jobs included. oclweb3's build has no test job, so there's none to mirror.package.json: theeslintscript adds--ext .jsx,.js. Without it, ESLint 8 lints only.jsfiles, sonpm run eslintskipped every.jsxfile.Test plan
build.yml's "Eslint" job (diffed).npm ci: CI's lint command is clean on this branch.npm run eslintnow reports an unused import in a throwaway.jsxfile (since removed); before, it skipped.jsx.🤖 Generated with Claude Code
https://claude.ai/code/session_01Lkm1wDY1zKSDTm2apzPJLi