Skip to content

OpenConceptLab/ocl_issues#2838 | Pull requests run the Eslint job, and npm run eslint lints .jsx - #57

Merged
paynejd merged 1 commit into
mainfrom
ocl_issues-2838-pr-checks
Sep 28, 2026
Merged

paynejd merged 1 commit into
mainfrom
ocl_issues-2838-pr-checks

Conversation

@paynejd

@paynejd paynejd commented Sep 28, 2026 •

Copy link
Copy Markdown
Member

Part of OpenConceptLab/ocl_issues#2838 (oclweb3). The same change as OpenConceptLab/oclmap#84.

Summary

Lint ran only in build.yml, on pushes to main, so a pull request showed no lint result before it merged. A lint failure surfaced only after the merge, where it blocks the build and deploy.

Change

  • .github/workflows/pr.yml (new): runs build.yml's "Eslint" job steps, unchanged, on every pull_request:

    • the start-prod.sh secret check
    • Node 22 with the npm cache, and npm ci
    • ./node_modules/eslint/bin/eslint.js --ext .jsx,.js src/

    It has a read-only token, and a newer push to the same PR cancels the older run. build.yml is untouched, deploy jobs included. oclweb3's build has no test job, so there's none to mirror.

  • package.json: the eslint script adds --ext .jsx,.js. Without it, ESLint 8 lints only .js files, so npm run eslint skipped every .jsx file.

Test plan

  • The workflow's steps are identical to build.yml's "Eslint" job (diffed).
  • Locally, after npm ci: CI's lint command is clean on this branch.
  • npm run eslint now reports an unused import in a throwaway .jsx file (since removed); before, it skipped .jsx.
  • The new "PR checks / Eslint" check ran on this PR and passed, every step.
  • Codex adversarial review, posted on this PR: clean.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Lkm1wDY1zKSDTm2apzPJLi

…d npm run eslint lints .jsx

Lint ran only in build.yml, on pushes to main, so a pull request showed no
lint result before it merged.

- .github/workflows/pr.yml runs build.yml's Eslint job steps unchanged on
  every pull_request (read-only token; a newer push cancels the older run).
  build.yml is untouched.
- package.json's eslint script adds --ext .jsx,.js; without it ESLint 8 lints
  only .js files, so npm run eslint skipped every .jsx.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Lkm1wDY1zKSDTm2apzPJLi
@paynejd paynejd added the type/infra CI/CD, deployment, infrastructure label Sep 28, 2026
@paynejd paynejd self-assigned this Sep 28, 2026

@paynejd paynejd left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex adversarial review, pass 1 (codex-cli 0.158, commit 0533942)

Scope: origin/main...HEAD, including build.yml and the new pr.yml. Read-only run. The report below is verbatim.

Outcome: Clean.


No real issues found. The lint jobs are structurally identical, both YAML files parse, and build.yml is unchanged. Repository searches found no callers broken by the eslint script change. No files were modified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/infra CI/CD, deployment, infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant