OpenConceptLab/ocl_online#299 | Banner: subscription dates (Nov 1 / Dec 1 grace period), "Learn more" and "See pricing" - #59
Merged
Conversation
…ec 1 grace period), "Learn more" and "See pricing" New announcement id, so the banner shows again to everyone who dismissed the preview one. Two links now, the letter and the pricing page, each kept on one line on narrow screens. "See pricing" is a new pricing_label key in en/es/zh; link_label stays "Learn more". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019j2N6BFoNmA32L2DHKZV41
paynejd
commented
Oct 1, 2026
paynejd
left a comment
Member
Author
There was a problem hiding this comment.
Codex adversarial review, pass 1 (codex-cli 0.159.2, commit 294f9c8)
Read-only. Posted verbatim. The destination pages it couldn't reach from its sandbox return 200 (checked after today's openconceptlab.org deploy).
Clean—no actionable findings in git diff origin/main...HEAD.
Checked stable keys, both links and unbroken labels, dismissal with the new ID, accessible labels, external-link safety, es/zh meaning and dates, URL paths, and tbv3 UTM tags. No stale references to the renamed constant remain.
Targeted ESLint, syntax parsing, locale JSON checks, and diff whitespace checks passed. No files modified.
Limitations: no full build or browser test; live destination pages could not be verified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Refs OpenConceptLab/ocl_online#299
Summary
Replaces the TBv3 public-preview announcement with the subscription-dates banner that openconceptlab.org shows from today.
subscription-dates-2026-10(the same id as the community site), so the banner shows again to everyone who dismissed the preview one.utm_campaign=subscription_dates)utm_campaign=subscription_dates)TBV3_ANNOUNCEMENT_URLis replaced byTBV3_ANNOUNCEMENT_LETTER_URLandTBV3_ANNOUNCEMENT_PRICING_URLinsrc/common/constants.js. The banner was the old constant's only user.announcement.link_labelstays "Learn more" (es "Más información", zh "了解更多"). "See pricing" is a newannouncement.pricing_labelkey (es "Ver precios", zh "查看价格").whiteSpace: 'nowrap', so a label never breaks in the middle on narrow screens.The banner doesn't record GA events, and this PR doesn't add any.
Test Plan
./node_modules/eslint/bin/eslint.js --ext .jsx,.js src/passesstart-prod.shsecret-shaped-variable check from the workflow passes--announcement-heightvar tracks it). At 1280px it fits on one line.target="_blank"andrel="noopener noreferrer"Notes
Don't merge until Jon's go; production deploy is manual.
🤖 Generated with Claude Code
https://claude.ai/code/session_019j2N6BFoNmA32L2DHKZV41