Fix dev logout redirect default and stale :test image trigger - #559
Merged
Merged
Conversation
config/openconext/parameters.yaml.dist is the local-development default config: every other URL in it (gateway, middleware, SAML endpoints) points at *.dev.openconext.local, but logout_redirect_url was still hardcoded to the public www.surf.nl production pages. This forced OpenConext-devconf's stepup docker-compose stack to bind-mount a full 95-line replacement parameters.yaml just to override this one key, duplicating and needing to stay in sync with this dist file. Fixing the default here lets devconf drop that override, matching how gateway/ middleware/ra already work with no devconf-side config file. en_GB and nl_NL now both redirect to the local test SP (ssp.dev.openconext.local), consistent with the rest of this file.
The build-push-test-docker-image workflow's trigger was left pointing at feature/build-and-publish-test-container, a branch that is already merged. Since then it can only run via manual workflow_dispatch and never rebuilds on a normal merge to main, so the :test image silently goes stale (the same issue found and fixed in OpenConext/Stepup-Gateway#666). Trigger the workflow on push to main instead, so the :test tag stays in sync with the default branch going forward.
kayjoosten
changed the title
johanib
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem 1: dev logout redirect points at production
config/openconext/parameters.yaml.distis the local-development default config. Every other URL in it (gateway, middleware, SAML endpoints) points at*.dev.openconext.local, butlogout_redirect_urlwas still hardcoded to the publicwww.surf.nlproduction pages.This inconsistency forces OpenConext-devconf's stepup docker-compose stack to bind-mount a full replacement
parameters.yamljust to override this one key, duplicating the whole file and needing to stay in sync with it. See OpenConext/OpenConext-devconf#98.Fix: point
logout_redirect_url(bothen_GBandnl_NL) at the local test SP (ssp.dev.openconext.local), consistent with the rest of the file. Once released in a test/dev image, devconf can drop itsselfservice/parameters.yamloverride and volume mount entirely, matching how gateway/middleware/ra already work with no devconf-side config file.Problem 2:
:testimage never rebuilds on merge to mainbuild-push-test-docker-image.ymltriggers onpush: branches: feature/build-and-publish-test-container, a branch that is already merged. It can therefore only run via manualworkflow_dispatchand never rebuilds on a normal merge tomain— the same stale-trigger bug already found and fixed in OpenConext/Stepup-Gateway#666.Fix: trigger the workflow on push to
maininstead, so the:testtag stays in sync with the default branch going forward (otherwise problem 1's fix above would never actually reach the published:testimage).