Repository navigation
Harden dev mode value - #56
Open
diondokter wants to merge 2 commits into
Open
diondokter wants to merge 2 commits into
diondokter wants to merge 2 commits into
Conversation
diondokter
force-pushed
the
devmode-sensitivity
branch
from
October 21, 2026 09:45
e22cfe6 to
a8e8c53
Compare
felipebalbi
reviewed
Oct 21, 2026
alamfarjadf
reviewed
Oct 21, 2026
|
And last open question / concern, but IMO not sure what else can be done (other than doing a check asm again, but where do we draw the line) |
|
@felipebalbi @diondokter would 0b11111100_11111100_00000011_11111100 work for the pattern? Basically !OnlyPki when computing and if it matches, we know OnlyPki not set (DEV mode can be enabled). |
diondokter
force-pushed
the
devmode-sensitivity
branch
from
November 2, 2026 09:10
a8e8c53 to
92733f5
Compare
Boot mode is now a struct
JamesHuard
approved these changes
Nov 2, 2026
JamesHuard
left a comment
JamesHuard
left a comment
Contributor
There was a problem hiding this comment.
The comments I would leave are not related to this PR, so I'll hold them for follow up issues in code quality if/when we get there
alamfarjadf
reviewed
Nov 2, 2026
| pub const DEV_VAL: Self = Self { | ||
| inverse_lifecycle: 0b11111100, // InvLifeCycleState::Develop | ||
| lifecycle: 0b00000011, // LifeCycleState::Develop | ||
| inverse_secure_boot: 0b00000011, // !SecSecBootEn::AllAllowed |
There was a problem hiding this comment.
The lower half of the pattern (SecBootEn) is almost all 0.
There was a problem hiding this comment.
Also, I am not sure you meant to write 'Sec' twice, it's just SecBootEn.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supercedes #54
Instead of collapsing dev mode into a bool, we keep it a very specific u32.
The
secure_boot_cfgis also read twice.This hopefully hardens against fault injections that saturate registers.
Everything after that uses a u32 that when saturated will not enable dev mode, so that should be good