Skip to content

Rename type-c-* to tcpm-* - #964

Merged
RobertZ2011 merged 6 commits into
OpenDevicePartnership:mainfrom
RobertZ2011:rename-tcpm
Sep 24, 2026
Merged

RobertZ2011 merged 6 commits into
OpenDevicePartnership:mainfrom
RobertZ2011:rename-tcpm

Conversation

@RobertZ2011

@RobertZ2011 RobertZ2011 commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

TCPM (Type-C port manager) is the more common name for this type of functionality.

@RobertZ2011 RobertZ2011 self-assigned this Sep 24, 2026
@RobertZ2011
RobertZ2011 requested a lite review from Copilot September 24, 2026 17:09
@RobertZ2011 RobertZ2011 added the BREAKING CHANGE Marks breaking changes label Sep 24, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The RT685 EVK still resolves tps6699x through incompatible old Type-C dependencies, blocking approval until its integration and lockfile are updated.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 Medium severity · 1 Low severity

Open (2)
What changed in this PR

Renames the Type-C service ecosystem to TCPM across crates, interfaces, tests, examples, manifests, lockfiles, CI, and ownership metadata.

Changes:

  • Renames service, interface, and mock crates to tcpm-*.
  • Updates imports, traits, controllers, services, tests, and examples.
  • Refreshes workspace configuration and dependency references.
File Summary
tcpm-service/​tests/​unconstrained.rs Updates renamed imports.
tcpm-service/​tests/​ucsi.rs Updates UCSI test imports and configuration.
tcpm-service/​tests/​power.rs Updates power test imports.
tcpm-service/​tests/​notifications.rs Updates notification imports.
tcpm-service/​tests/​debug_accessory.rs Updates accessory test imports.
tcpm-service/​tests/​common/​mod.rs Migrates shared test infrastructure.
tcpm-service/​src/​util.rs Adds service utility conversions.
tcpm-service/​src/​task.rs Updates TCPM interface usage.
tcpm-service/​src/​service/​ucsi.rs Updates UCSI service integration.
tcpm-service/​src/​service/​registration.rs Updates registration traits.
tcpm-service/​src/​service/​power.rs Updates power service integration.
tcpm-service/​src/​service/​mod.rs Updates service module exports.
tcpm-service/​src/​service/​event_receiver.rs Updates service event handling.
tcpm-service/​src/​service/​config.rs Updates service configuration.
tcpm-service/​src/​lib.rs Updates service event imports.
tcpm-service/​src/​controller/​ucsi.rs Updates UCSI controller implementation.
tcpm-service/​src/​controller/​type_c.rs Updates Type-C controller implementation.
tcpm-service/​src/​controller/​state.rs Updates controller state.
tcpm-service/​src/​controller/​retimer.rs Updates retimer implementation.
tcpm-service/​src/​controller/​power.rs Updates power implementation.
tcpm-service/​src/​controller/​pd.rs Updates PD implementation.
tcpm-service/​src/​controller/​mod.rs Updates controller exports and bounds.
tcpm-service/​src/​controller/​max_sink_voltage.rs Updates sink-voltage implementation.
tcpm-service/​src/​controller/​macros.rs Updates controller macros.
tcpm-service/​src/​controller/​event.rs Updates controller event types.
tcpm-service/​src/​controller/​event_receiver.rs Updates controller event imports.
tcpm-service/​src/​controller/​electrical_disconnect.rs Updates disconnect implementation.
tcpm-service/​src/​controller/​config.rs Updates controller configuration.
tcpm-service/​Cargo.toml Renames the service package and dependencies.
tcpm-interface/​src/​util.rs Updates interface utilities.
tcpm-interface/​src/​ucsi.rs Defines the UCSI interface.
tcpm-interface/​src/​service/​notification.rs Defines service notifications.
tcpm-interface/​src/​service/​mod.rs Exposes service modules.
tcpm-interface/​src/​service/​event.rs Defines service events and notifiers.
tcpm-interface/​src/​port/​type_c.rs Defines the port Type-C trait.
tcpm-interface/​src/​port/​retimer.rs Defines the port retimer trait.
tcpm-interface/​src/​port/​power.rs Defines port power traits.
tcpm-interface/​src/​port/​pd.rs Defines port PD traits.
tcpm-interface/​src/​port/​notification.rs Defines port notification traits.
tcpm-interface/​src/​port/​mod.rs Exposes port modules.
tcpm-interface/​src/​port/​max_sink_voltage.rs Defines the sink-voltage trait.
tcpm-interface/​src/​port/​event.rs Defines port events and notifiers.
tcpm-interface/​src/​port/​electrical_disconnect.rs Defines the disconnect trait.
tcpm-interface/​src/​lib.rs Defines the renamed interface crate.
tcpm-interface/​src/​controller/​type_c.rs Defines the controller Type-C trait.
tcpm-interface/​src/​controller/​retimer.rs Defines the controller retimer trait.
tcpm-interface/​src/​controller/​power.rs Defines controller power traits.
tcpm-interface/​src/​controller/​pd.rs Defines controller PD traits.
tcpm-interface/​src/​controller/​mod.rs Exposes controller modules.
tcpm-interface/​src/​controller/​max_sink_voltage.rs Defines controller sink-voltage traits.
tcpm-interface/​src/​controller/​electrical_disconnect.rs Defines the controller disconnect trait.
tcpm-interface/​src/​control/​vdm.rs Defines VDM control types.
tcpm-interface/​src/​control/​usb.rs Defines USB control configuration.
tcpm-interface/​src/​control/​type_c.rs Defines Type-C control state.
tcpm-interface/​src/​control/​tbt.rs Defines Thunderbolt configuration.
tcpm-interface/​src/​control/​svid.rs Defines SVID representations.
tcpm-interface/​src/​control/​retimer.rs Defines retimer state types.
tcpm-interface/​src/​control/​power.rs Defines power-state types.
tcpm-interface/​src/​control/​pd.rs Defines PD status and contract types.
tcpm-interface/​src/​control/​mod.rs Exposes control modules.
tcpm-interface/​src/​control/​dp.rs Defines DisplayPort control types.
tcpm-interface/​Cargo.toml Renames the interface package.
tcpm-interface-test-mocks/​src/​lib.rs Exposes controller mocks.
tcpm-interface-test-mocks/​src/​controller/​ucsi.rs Updates UCSI mocks.
tcpm-interface-test-mocks/​src/​controller/​pd.rs Updates PD mocks.
tcpm-interface-test-mocks/​src/​controller/​mod.rs Updates mock exports and types.
tcpm-interface-test-mocks/​src/​controller/​max_sink_voltage.rs Updates sink-voltage mocks.
tcpm-interface-test-mocks/​Cargo.toml Renames test-mock dependencies.
tcpm-interface-mocks/​tests/​connect_disconnect.rs Updates mock integration tests.
tcpm-interface-mocks/​src/​port/​mod.rs Updates port mocks.
tcpm-interface-mocks/​src/​lib.rs Updates mock crate documentation and exports.
tcpm-interface-mocks/​Cargo.toml Renames mock dependencies.
examples/​std/​src/​lib/​type_c/​mock_controller.rs Migrates the standard example controller.
examples/​std/​Cargo.toml Updates standard example dependencies.
examples/​std/​Cargo.lock Refreshes standard example packages.
examples/​rt685s-evk/​src/​bin/​type_c.rs Migrates the RT685 TCPM example.
examples/​rt685s-evk/​src/​bin/​type_c_cfu.rs Migrates the RT685 CFU example.
examples/​rt685s-evk/​Cargo.toml Updates RT685 dependencies; tps6699x still targets the old graph.
examples/​rt685s-evk/​Cargo.lock Retains old Type-C dependencies for tps6699x.
CODEOWNERS Updates ownership paths.
Cargo.toml Renames workspace members and dependencies.
Cargo.lock Refreshes workspace package names.
.github/​workflows/​check.yml Updates excluded crate names.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread examples/rt685s-evk/Cargo.toml Outdated
Comment thread CODEOWNERS Outdated
@RobertZ2011
RobertZ2011 marked this pull request as ready for review September 24, 2026 21:02
@RobertZ2011
RobertZ2011 requested review from a team as code owners September 24, 2026 21:02
@RobertZ2011 RobertZ2011 added this to EC Sep 24, 2026
@RobertZ2011 RobertZ2011 moved this to In Progress in EC Sep 24, 2026
@RobertZ2011
RobertZ2011 merged commit c190e9d into OpenDevicePartnership:main Sep 24, 2026
16 checks passed
@RobertZ2011
RobertZ2011 deleted the rename-tcpm branch September 24, 2026 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BREAKING CHANGE Marks breaking changes

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants