Repository navigation
Conversation
Adds a generic pr-template rule that fails when the PR description drops one of the configured template sections or leaves a required one empty. Enabled on core for Proposed change, Type of change and Checklist. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A `### Details` heading inside `## Proposed change` ended the section, so a filled-in description read as empty. Sections now run until the next heading of the same or a higher level. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
implements
What was said in #54
When a section of a pr template thats not meant to be deleted gets deleted in the core repo it gets flagged by the ha bot
tests
I've tested locally (so no actual comments) this against 200 prs, 192 passed, 6 were PRs from bots, which were skipped and 2 were failures.
The two that failed were
home-assistant/core#192030
home-assistant/core#191967
both have deleted a portion of the template
Type of change
Additional information
draft until i finish reviewing code
this only covers the core repo, follow ups will be made for other repos. However since the rule lives in src/github/rules it can be reused in other repos easily.
Checklist
mise run test). Your PR cannot be merged unless tests pass.mise run check).mise run format).If behaviour, configuration, or environment variables changed:
README.mdand.env.examplehave been updated accordingly.