hi3518ev300_lite_bathhouse: rename to yuancam-dgk423403 - #153
Conversation
The device is a YuanCam-branded (HQLS/hdwificam OEM) HI3518EV300 board —
confirmed on a lab unit via its Factory.bin/SysParam.bin tags
("YuanCamFactory"/"YuanCamSysparam") and its P2P device id
(DGK-423403-YZHGE). Rename the placeholder "Bathhouse" profile to a
proper vendor-model name and fill in the sensor, identified on hardware
with ipctool as JXH62 (previously "?" in the README table). The
defconfig, customizer.sh and excludes list carry over unchanged except
for the upgrade URL, which now points at the renamed release asset.
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can switch off images and animations for a plain-text comment |
PR Summary by QodoRename Bathhouse profile to YuanCam DGK-423403
AI Description
Diagram
High-Level Assessment
Files changed (4)
|
… Wi-Fi) (#152) The first ssc337de_lite device in the tree to ship an excludes list: it prunes 17 of the 18 sensors OpenIPC/sensors builds for infinity6b0 and keeps sc401ai, the board's own. Wi-Fi is an MT7601U on the vendor STA driver, so the device carries its own /etc/wireless/usb with the gpio 14 power cycle ahead of the modprobe, and execs modprobe so the profile's exit status is the module's rather than an unconditional success. The overlay is registered in .github/firmware-drift.json against the current firmware blob rather than left to drift silently. Built green on CI before a rebase over #151 and #153, which collided only on the README device table.
Summary
hi3518ev300_lite_bathhousedevice profile tohi3518ev300_lite_yuancam-dgk423403. The placeholder "Bathhouse" name was a joke/stub; on a physical lab unit of this exact board (HI3518EV300, RTL8188FU_USB, NOR_8M — matches the existing profile's spec) I identified the real OEM branding from/mnt/userdata/config/Factory.binandSysParam.bin, which both carry aYuanCam*tag, plus the camera's own P2P device idDGK-423403-YZHGE.?→JXH62), identified on hardware viaipctool -s.customizer.sh'sfw_setenv upgradeURL to match the renamed release asset name.BR2_PACKAGE_RTL8188FU_OPENIPC=yonly (nor8188eu/mt7601u), which is correct for this board's actual Wi-Fi chip (Realtek RTL8188FU, confirmed vialsusb/lsmodon hardware).hi3518ev300_lite.list(named after soc+flavor, not the device, per repo convention).Sensor (JXH62) support isn't wired into
hisilicon-opensdk.mkfor thehi3516ev200family yet, so this staysresearchstatus in the table rather than claiming video works — that's separate, larger work not included here.Test plan
./builder.sh hi3518ev300_lite_yuancam-dgk423403resolves the device tree correctly (defconfig/customizer/excludes all present and named per convention).ipctool -c/-s,lsusb,lsmod, Factory.bin/SysParam.bin strings) performed on a physical lab unit of this board over telnet.