t31_lite_zte-k545: ship the excludes list the device was missing - #154
t31_lite_zte-k545: ship the excludes list the device was missing#154openipc-ai wants to merge 1 commit into
Conversation
#151 added the K545 without general/scripts/excludes/t31_lite.list, which README lists among the files a registered device must have. Nothing failed for the want of it -- the image builds and the author has it running -- but it builds close to the edge: rootfs.squashfs came out at 4560KB of the 5120KB an 8M layout allows, 560KB of headroom, while the uncompressed tree is 14.2MB. Every sensor the T31 osdrv ships is in there, and the board has exactly one. The list is t31_lite_chinatelecom-y4h-50's, which is the conservative of the two in the tree: it prunes other sensors' .bin, .yaml and .ko and stops there. The tc70-v3 variant also globs kernel/drivers/net/wireless/*, and this board's Wi-Fi is the out-of-tree atbm60xx module, so that one is not worth the risk here for the few KB it would add. Verified against the osdrv rather than by pattern: it ships sc4336-t31.bin and sc4336.yaml, and neither appears in the list, so the K545's own sensor survives the prune. The devices this list came from run the same SoC and flavour, so the paths are the ones this image actually has. The sibling t31_lite_zte-k540 has the same gap and the same sensor; it is left alone here for its author to decide.
PR Summary by QodoAdd missing K545 sensor exclusion manifest
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can switch off images and animations for a plain-text comment |
|
Closing this: the build went green and then told me the change does nothing. The premise was wrong. ifeq ($(OPENIPC_SNS_MODEL),)
... installs every *.yaml and every params/*-t31.bin
else
... installs $(OPENIPC_SNS_MODEL).yaml and $(OPENIPC_SNS_MODEL)-$(OPENIPC_SOC_MODEL).bin
endifThe K545 sets That also explains the three t31_lite devices that do ship this list: So the rootfs sits at 4564KB/5120KB because of majestic, the webui and the kernel modules, not because of stray sensor assets, and this file would only have added a permanent "65 of 65 entries matched no file" line to every build of this device. Worth noting for the next reader: the automated review on #151 flagged the missing list as a rule violation, and README does list it among a device's required files. For a device that pins |
#151 added the K545 without
general/scripts/excludes/t31_lite.list, one of the files README lists as required for a registered device. I merged it anyway and offered to follow up, which was the wrong call — this is that fix.Nothing failed for the want of it: the image builds and the author has the camera running. But it builds close to the edge. From #151's own CI run:
Every sensor the T31 osdrv ships is in that rootfs, and the board has exactly one (SC4336).
The list is
t31_lite_chinatelecom-y4h-50's, which is the conservative of the two in the tree: it prunes other sensors'.bin,.yamland.koand stops there. Thetp-link-tapo-tc70-v3variant additionally globskernel/drivers/net/wireless/*, and this board's Wi-Fi is the out-of-tree atbm60xx module, so that one is not worth the risk here for the few KB it would add.Checked rather than assumed: the osdrv ships
sc4336-t31.binandsc4336.yaml, and neither appears in the list, so the K545's own sensor survives the prune.ci-matrix.py --stdinnarrows this to the one device, so the build in this PR is the measurement — the size report will say how much headroom it bought.The sibling
t31_lite_zte-k540has the same gap and the same sensor. Left alone here for its author to decide.On the other thing I raised at merge time, the 8M
BR2_OPENIPC_FLASH_SIZEagainst aNOR_16MREADME row: that one is not a defect, and I should not have asked. #151's description already says it — "The board has 16 MiB NOR, while the profile intentionally keeps the same 8 MiB OpenIPC image/partition footprint used by K540."