excludes: strip two sensors these boards cannot use, and a dead f2fs entry - #155
excludes: strip two sensors these boards cannot use, and a dead f2fs entry#155openipc-ai wants to merge 1 commit into
Conversation
…entry sensor_sc3336_mipi.ko, sensor_os03b10_mipi.ko and sc3336.bin arrived in sigmastar-osdrv-sensors after the ssc333 exclude lists were written, so meari-speed-6s (JXF37) and babysense-see-hd-ip206 (GC2053) have been shipping both sensors they cannot use. No board in the README table uses SC3336 or OS03B10. Scoped to those two devices on purpose. The other nine infinity6b0 profiles carry the same two files, but ssc333_lite_tp-link-tapo-c110-v26 has "?" in the sensor column and stripping a sensor blob from a board whose sensor nobody has recorded is not a safe guess. f2fs.ko has not been built since F2FS was switched off upstream (# CONFIG_F2FS_FS is not set in hi3518ev200.generic.config), so five hi3518ev200_lite lists have been asking the rootfs script to delete a file that is never there, and every build prints "1 of 55 entries matched no file" for it. The warning is how a stale exclude gets noticed, so it should not be permanently on. Measured by rebuilding the shipped nightly-20260909-e0a643f images with the build's own squashfs parameters (the unmodified tree reproduces them byte-exactly): meari 5108 -> 5092 KB, babysense 5104 -> 5092 KB.
PR Summary by QodoTrim unsupported sensors and stale F2FS exclusions
AI Description
Diagram
High-Level Assessment
Files changed (7)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can switch off images and animations for a plain-text comment |
Summary
Two exclude-list corrections, both files the boards cannot use. This is the
builder half of the 8 MB NOR overflow; the bytes that actually fix it are in
OpenIPC/firmware#2399, and this should land alongside it.
ssc333_lite.listonmeari-speed-6sandbabysense-see-hd-ip206neverlearnt about two sensors.
sensor_sc3336_mipi.ko,sensor_os03b10_mipi.koand
sc3336.binwere added tosigmastar-osdrv-sensorsafter these lists werewritten, so every image of these two boards has been carrying them. Meari is
JXF37, Babysense is GC2053; neither can use either sensor, and no board in the
README's table uses SC3336 or OS03B10 at all.
Scoped to these two devices deliberately. The other nine infinity6b0 profiles
ship the same two files, but
ssc333_lite_tp-link-tapo-c110-v26has?in thesensor column of the README, and I am not going to strip a sensor blob from a
board whose sensor nobody has written down. Worth a follow-up once that is
identified.
Five
hi3518ev200_lite.listfiles carry a dead entry.f2fs.kohas notbeen built since F2FS was switched off upstream —
# CONFIG_F2FS_FS is not setin
hi3518ev200.generic.config— and every build has been printingfor it. No bytes either way; it removes a warning that otherwise trains you to
ignore that line, which is the line that tells you an exclude has gone stale.
Measured
Rebuilt from the shipped
nightly-20260909-e0a643fimages with the samesquashfs parameters the build uses (
-noappend -b 131072 -comp xzunderfakeroot). The unmodified tree reproduces each published image byte-exactly —
5,238,784 for switcam-hs303 and 5,226,496 for babysense — so these are real
flash, not compression estimates.
ssc333_lite_meari-speed-6sssc333_lite_babysense-see-hd-ip206Against the 5128 KB these two measured on the failing run, that is not on its
own enough to clear 5120 KB with any margin worth having — hence the firmware
PR, which takes another 32 KB out of the same two images.
ci-matrix.py --self-testpasses (114 devices, 15 smoke, 39 cases).