Skip to content

excludes: strip two sensors these boards cannot use, and a dead f2fs entry - #155

Open
openipc-ai wants to merge 1 commit into
masterfrom
excludes-unused-sensors-and-dead-f2fs
Open

excludes: strip two sensors these boards cannot use, and a dead f2fs entry#155
openipc-ai wants to merge 1 commit into
masterfrom
excludes-unused-sensors-and-dead-f2fs

Conversation

@openipc-ai

Copy link
Copy Markdown
Contributor

Summary

Two exclude-list corrections, both files the boards cannot use. This is the
builder half of the 8 MB NOR overflow; the bytes that actually fix it are in
OpenIPC/firmware#2399, and this should land alongside it.

ssc333_lite.list on meari-speed-6s and babysense-see-hd-ip206 never
learnt about two sensors.
sensor_sc3336_mipi.ko, sensor_os03b10_mipi.ko
and sc3336.bin were added to sigmastar-osdrv-sensors after these lists were
written, so every image of these two boards has been carrying them. Meari is
JXF37, Babysense is GC2053; neither can use either sensor, and no board in the
README's table uses SC3336 or OS03B10 at all.

Scoped to these two devices deliberately. The other nine infinity6b0 profiles
ship the same two files, but ssc333_lite_tp-link-tapo-c110-v26 has ? in the
sensor column of the README, and I am not going to strip a sensor blob from a
board whose sensor nobody has written down. Worth a follow-up once that is
identified.

Five hi3518ev200_lite.list files carry a dead entry. f2fs.ko has not
been built since F2FS was switched off upstream — # CONFIG_F2FS_FS is not set
in hi3518ev200.generic.config — and every build has been printing

excludes: /lib/modules/4.9.37/kernel/fs/f2fs/f2fs.ko matched no file
excludes: 1 of 55 entries in hi3518ev200_lite.list matched no file

for it. No bytes either way; it removes a warning that otherwise trains you to
ignore that line, which is the line that tells you an exclude has gone stale.

Measured

Rebuilt from the shipped nightly-20260909-e0a643f images with the same
squashfs parameters the build uses (-noappend -b 131072 -comp xz under
fakeroot). The unmodified tree reproduces each published image byte-exactly —
5,238,784 for switcam-hs303 and 5,226,496 for babysense — so these are real
flash, not compression estimates.

board rootfs.squashfs after
ssc333_lite_meari-speed-6s 5108 KB 5092 KB
ssc333_lite_babysense-see-hd-ip206 5104 KB 5092 KB

Against the 5128 KB these two measured on the failing run, that is not on its
own enough to clear 5120 KB with any margin worth having — hence the firmware
PR, which takes another 32 KB out of the same two images.

ci-matrix.py --self-test passes (114 devices, 15 smoke, 39 cases).

…entry

sensor_sc3336_mipi.ko, sensor_os03b10_mipi.ko and sc3336.bin arrived in
sigmastar-osdrv-sensors after the ssc333 exclude lists were written, so
meari-speed-6s (JXF37) and babysense-see-hd-ip206 (GC2053) have been shipping
both sensors they cannot use. No board in the README table uses SC3336 or
OS03B10.

Scoped to those two devices on purpose. The other nine infinity6b0 profiles
carry the same two files, but ssc333_lite_tp-link-tapo-c110-v26 has "?" in the
sensor column and stripping a sensor blob from a board whose sensor nobody has
recorded is not a safe guess.

f2fs.ko has not been built since F2FS was switched off upstream
(# CONFIG_F2FS_FS is not set in hi3518ev200.generic.config), so five
hi3518ev200_lite lists have been asking the rootfs script to delete a file that
is never there, and every build prints "1 of 55 entries matched no file" for
it. The warning is how a stale exclude gets noticed, so it should not be
permanently on.

Measured by rebuilding the shipped nightly-20260909-e0a643f images with the
build's own squashfs parameters (the unmodified tree reproduces them
byte-exactly): meari 5108 -> 5092 KB, babysense 5104 -> 5092 KB.
@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

Trim unsupported sensors and stale F2FS exclusions

🐞 Bug fix ⚙️ Configuration changes 🕐 10-20 Minutes

Grey Divider

AI Description

• Excludes unsupported SC3336 and OS03B10 assets from two SSC333 board images.
• Removes obsolete F2FS exclusions from five HI3518EV200 profiles, restoring meaningful stale-entry
 warnings.
• Reduces affected SSC333 squashfs images by 12–16 KB without altering uncertain sensor profiles.
Diagram

graph TD
  S["Sensor Assets"] --> X["SSC333 Lists"] --> B["Rootfs Builder"] --> I["Board Images"]
  F["F2FS Disabled"] --> H["HI3518 Lists"] --> B
Loading
High-Level Assessment

The board-specific manifest edits are the safest approach: they reclaim space only on boards with documented JXF37 or GC2053 sensors and directly remove known-stale F2FS entries. A platform-wide sensor exclusion was considered but should remain deferred because at least one related board has an unidentified sensor and could require these assets.

Files changed (7) +6 / -5

Bug fix (7) +6 / -5
hi3518ev200_lite.listRemove obsolete Qtech F2FS exclusion +0/-1

Remove obsolete Qtech F2FS exclusion

• Removes the f2fs.ko path because the module is no longer built. This prevents a persistent unmatched-exclusion warning during rootfs generation.

devices/hi3518ev200_lite_qtech-qvc-ipc-136w/general/scripts/excludes/hi3518ev200_lite.list

hi3518ev200_lite.listRemove obsolete Smartwares F2FS exclusion +0/-1

Remove obsolete Smartwares F2FS exclusion

• Drops the stale f2fs.ko exclusion from the Smartwares profile, eliminating an expected no-match warning.

devices/hi3518ev200_lite_smartwares-cip-37210/general/scripts/excludes/hi3518ev200_lite.list

hi3518ev200_lite.listRemove obsolete Switcam V2 F2FS exclusion +0/-1

Remove obsolete Switcam V2 F2FS exclusion

• Removes the unbuildable f2fs.ko path so stale-exclusion diagnostics remain actionable.

devices/hi3518ev200_lite_switcam-hs303-v2/general/scripts/excludes/hi3518ev200_lite.list

hi3518ev200_lite.listRemove obsolete Switcam F2FS exclusion +0/-1

Remove obsolete Switcam F2FS exclusion

• Deletes the dead f2fs.ko exclusion from the HS303 profile. The rootfs builder will no longer report it as unmatched.

devices/hi3518ev200_lite_switcam-hs303/general/scripts/excludes/hi3518ev200_lite.list

hi3518ev200_lite.listRemove obsolete VStarcam F2FS exclusion +0/-1

Remove obsolete VStarcam F2FS exclusion

• Removes the stale F2FS module path, aligning the manifest with the disabled kernel feature.

devices/hi3518ev200_lite_vstarcam-c8892wip/general/scripts/excludes/hi3518ev200_lite.list

ssc333_lite.listExclude unsupported Babysense sensor assets +3/-0

Exclude unsupported Babysense sensor assets

• Adds the SC3336 firmware blob plus SC3336 and OS03B10 kernel modules to the exclusion list. The GC2053-based board cannot use these assets, reducing its measured squashfs image by 12 KB.

devices/ssc333_lite_babysense-see-hd-ip206/general/scripts/excludes/ssc333_lite.list

ssc333_lite.listExclude unsupported Meari sensor assets +3/-0

Exclude unsupported Meari sensor assets

• Adds the SC3336 firmware blob plus SC3336 and OS03B10 kernel modules to the exclusion list. The JXF37-based board cannot use these assets, reducing its measured squashfs image by 16 KB.

devices/ssc333_lite_meari-speed-6s/general/scripts/excludes/ssc333_lite.list

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can switch off images and animations for a plain-text comment

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant