Add Smitch 360 PTZ (HI3518EV300, JXF23, RTL8188FU, NOR 16MB) - #82
Add Smitch 360 PTZ (HI3518EV300, JXF23, RTL8188FU, NOR 16MB)#82siddhant01 wants to merge 1 commit into
Conversation
|
Thanks for this, and sorry it sat so long. It is in good shape — reviewed against current master. Good news first: you no longer need a What checks out
Three small things before merge
Rebase on master with those and CI will tell us whether it builds. |
openipc-ai
left a comment
There was a problem hiding this comment.
Marking this changes-requested so it shows up as such in the queue. Nothing new — the same three items from my review above are still outstanding:
- Drop
BR2_PACKAGE_JSONFILTER=yfrom the defconfig (#128 removed it from all 97 defconfigs after firmware/#2304). - Drop the unrelated README wording change on the "Create firmware with built-in credentials" heading. The device-table row is welcome, keep that.
customizer.shis missing its trailing newline.
The branch still merges cleanly, so no rebase is needed — push those three and CI will build the device.
Device details
Notes
rtl8188fu-hi3518ev300-t5810hct-m02already merged in firmware repo: add wifi support for t5810hct-m02 board firmware#1373
Status
video-yes, wifi-yes, motors-no