Skip to content

Add Smitch 360 PTZ (HI3518EV300, JXF23, RTL8188FU, NOR 16MB) - #82

Open
siddhant01 wants to merge 1 commit into
OpenIPC:masterfrom
siddhant01:add-smitch-360ptz
Open

Add Smitch 360 PTZ (HI3518EV300, JXF23, RTL8188FU, NOR 16MB)#82
siddhant01 wants to merge 1 commit into
OpenIPC:masterfrom
siddhant01:add-smitch-360ptz

Conversation

@siddhant01

Copy link
Copy Markdown

Device details

  • Model: Smitch 360 PTZ (Indian brand, servers closed)
  • Board: T5810hct-m02
  • SOC: HI3518EV300
  • Flash: EN25QH128 (16MB NOR)
  • RAM: 64MB
  • WiFi: RTL8188FU (internal USB, GPIO 40 power-up)
  • Sensor: JXF23
  • Variant: ultimate

Notes

  • WiFi power-up via GPIO 40 — wlandev profile rtl8188fu-hi3518ev300-t5810hct-m02
    already merged in firmware repo: add wifi support for t5810hct-m02 board firmware#1373
  • QR WiFi provisioning tested and working
  • Motors, IR cut, LEDs, reset button not yet mapped (GPIO unknown)

Status

video-yes, wifi-yes, motors-no

@openipc-ai

Copy link
Copy Markdown
Contributor

Thanks for this, and sorry it sat so long. It is in good shape — reviewed against current master.

Good news first: you no longer need a master.yml matrix entry. Since #120 the build matrix is read off the tree, so a device is registered simply by having devices/<dir>/.../<dir>_defconfig. Your device therefore registers itself, and this repo now builds pull requests — a push here will build hi3518ev300_ultimate_smitch-360ptz-t5810hct-m02 for the first time, narrowed to just that one device. (CLAUDE.md step 6 still describes the old flow; that's on us to fix.)

What checks out

  • fw_setenv wlandev rtl8188fu-hi3518ev300-t5810hct-m02 — already upstream in firmware's general/overlay/etc/wireless/usb, complete with a # HI3518EV300 t5810hct-m02 comment. So the Wi-Fi half is landed.
  • The exclude list correctly keeps libsns_f23.so, jxf23_i2c_1080p.ini and iq/f23.ini for a JXF23 board, and its name (hi3518ev300_ultimate.list) matches the soc+flavour convention.
  • The UBI block matches what both hi3516ev300_ultimate_* devices do, so that's right for the family.

Three small things before merge

  1. Drop BR2_PACKAGE_JSONFILTER=y. package: stop selecting jsonfilter, mirroring firmware #2304 #128 removed it from all 97 defconfigs after firmware/#2304, because it drags in libubox for nothing on a device that enables neither uqmi-openipc nor wifibroadcast-ng — it was worth 32KB and had three boards over their rootfs cap.
  2. Please drop the README wording change on the "Create firmware with built-in credentials" heading — it's unrelated to the device and just makes the diff harder to read. The device-table row is welcome, keep that.
  3. customizer.sh is missing its trailing newline.

Rebase on master with those and CI will tell us whether it builds.

@openipc-ai openipc-ai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking this changes-requested so it shows up as such in the queue. Nothing new — the same three items from my review above are still outstanding:

  1. Drop BR2_PACKAGE_JSONFILTER=y from the defconfig (#128 removed it from all 97 defconfigs after firmware/#2304).
  2. Drop the unrelated README wording change on the "Create firmware with built-in credentials" heading. The device-table row is welcome, keep that.
  3. customizer.sh is missing its trailing newline.

The branch still merges cleanly, so no rebase is needed — push those three and CI will build the device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants