Skip to content

Enable Javadoc doclint (all,-missing) with failOnWarnings on JDK 11 and JDK 26#1070

Open
vharseko wants to merge 3 commits into
OpenIdentityPlatform:masterfrom
vharseko:javadoc-doclint-failonwarnings
Open

Enable Javadoc doclint (all,-missing) with failOnWarnings on JDK 11 and JDK 26#1070
vharseko wants to merge 3 commits into
OpenIdentityPlatform:masterfrom
vharseko:javadoc-doclint-failonwarnings

Conversation

@vharseko

Copy link
Copy Markdown
Member

Summary

Enables Javadoc doclint (all,-missing) with failOnWarnings=true, and fixes every resulting error and warning across all modules so mvn javadoc:javadoc is green on both JDK 11 and JDK 26.

Configuration

  • Root pom.xml: doclint=all,-missing (inherited property), failOnWarnings=true, maven-javadoc-plugin 3.11.2 → 3.12.0.
  • Javadoc <source>8</source><source>11</source> (matches the compiler) plus --add-exports for the four JDK-internal sun.* packages a few legacy classes use. Together these keep JDK 26 free of [removal] platform-deprecation warnings (e.g. AccessController) without touching any of the ~350 usages.
  • Removed the per-module javadoc <skip> overrides so docs build everywhere. openam-mcp-server stays skipped (Java 17 records can't be processed by the Javadoc tool on the JDK 11 doc baseline).
  • .gitattributes: *.html text eol=lf so JDK 25/26 doclint doesn't treat CR (from CRLF) as part of a multi-line tag name.

Fixes

Javadoc-comment-only changes across ~60 modules (no runtime logic changed): authored real @param/@return/@throws descriptions, fixed HTML (<tt><code>, empty/self-closing <p>, escaped </>/& or {@code}), resolved or {@code}-converted unreachable {@link}, removed @inheritDoc on non-overriding methods, corrected exception not thrown, and sanitized the frozen JAXB schema modules. Two SNMP .mib DESCRIPTIONs had a raw & (copied verbatim into generated Javadoc) reworded to and. All modified files carry a Portions Copyrighted 2026 3A Systems, LLC line.

Verification

Full-reactor mvn javadoc:javadoc with failOnWarnings=true (-fae): BUILD SUCCESS on JDK 11 and JDK 26, zero doclint findings, zero [removal] warnings.

…nd JDK 26

- pom: doclint=all,-missing via inherited property; failOnWarnings=true;
  maven-javadoc-plugin 3.11.2 -> 3.12.0; source 8 -> 11 with --add-exports for
  the sun.* internal APIs a few legacy classes use (keeps JDK 26 free of
  [removal] warnings without touching AccessController usages)
- Remove per-module javadoc skips so docs build everywhere; keep openam-mcp-server
  skipped (Java 17 records cannot be processed on the JDK 11 doc baseline)
- .gitattributes: check out *.html with LF so JDK 25/26 doclint does not treat CR
  as part of a multi-line tag name
- Fix every doclint error/warning across all modules: authored real @param/@return/
  @throws descriptions, HTML/entity/self-closing/{@link} fixes, JAXB schema sanitize
@vharseko vharseko requested a review from maximthomas July 13, 2026 07:44
@vharseko vharseko added documentation Documentation, README, or javadoc build jdk10+ labels Jul 13, 2026
vharseko added 2 commits July 13, 2026 10:48
…lonwarnings

# Conflicts:
#	openam-test/pom.xml
…om master)

SampleAuth.init: author the three empty @param descriptions so the newly
merged openam-samples module passes failOnWarnings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build documentation Documentation, README, or javadoc jdk10+

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant