Conversation
…escape of the baseline check - The self-test of check.sh checks that a known entry which is gone gives exactly one "No longer found" notice and exit 0. - It feeds a message with % and CR to a new and to a stale entry, and expects 50%25%0D in both the ::error and the ::notice line. - On failure, the self-tests quote the output of check.sh and head-meta.sh with "> " on stderr: the runner reads workflow commands there too, and their ::error lines would become annotations of the pull request.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39 — the third review round of #28 (review 5389582272), done on
master, where the code arrived through #38.Changes
.github/workflows/build.yml:::notice title=No longer found; …line and exit 0.50%+ CR, as a new Antora error and as a stale known one, must appear as50%25%0Din both the::errorand the::noticeline.check.sh/head-meta.shgoes to stderr quoted with>, because the runner reads workflow commands on stderr too and its::errorlines would become annotations of the pull request. This is done in all three places, including the two that [#36] [#37] CI: check link anchors, head meta tags and the robots.txt Sitemap line #38 added.Verification
The steps were cut out of
build.ymland run locally in an Ubuntu container (bash 5, jq, node):failed=true, swappedcommoperands,.errormapinbroken-links.jq,comm -13→comm -12,fixed=,::notice→::debug, and the CR escape deleted in both places, in the error only, or in the notice only; the head meta self-test fails against a brokenhead-meta.sh;::.The
<br>replacement in the "Errors and warnings" table of the job summary stays untested, as noted in the review.