Skip to content

feat!: Require openjd-model 0.14 - #372

Merged
seant-aws merged 1 commit into
OpenJobDescription:mainlinefrom
seant-aws:widen-openjd-model-cap
Oct 19, 2026
Merged

seant-aws merged 1 commit into
OpenJobDescription:mainlinefrom
seant-aws:widen-openjd-model-cap

Conversation

@seant-aws

Copy link
Copy Markdown
Contributor

Fixes: N/A — dependency maintenance

What was the problem/requirement? (What/Why)

openjd-model 0.14.0 was released on 2026-10-16, but the openjd-model dependency range in this package (>= 0.13, < 0.14) prevents resolving it.

What was the solution? (How)

Widen the openjd-model dependency range from >= 0.13, < 0.14 to >= 0.14, < 0.15.

What is the impact of this change?

Consumers of this package will resolve openjd-model 0.14.x instead of 0.13.x. openjd-model 0.14.0 brings Rust crate bumps (expr 0.12.0, model 0.13.0, sessions 0.8.1), stricter template validation, and a Pydantic 2.14 typing fix.

How was this change tested?

See DEVELOPMENT.md for information on running tests.

  • Have you run the unit tests?

Yes — hatch run test: 1009 passed, 46 skipped, 16 xfailed. hatch run lint: clean (ruff + mypy, 94 source files). No code changes required.

Was this change documented?

  • Are relevant docstrings in the code base updated?

N/A — no code changes, only a version pin update and its associated comment.

Is this a breaking change?

A breaking change is one that modifies a public contract in a way that is not backwards compatible. See the
Public Interfaces section
of the DEVELOPMENT.md for more information on the public contracts.

If so, then please describe the changes that users of this package must make to update their scripts, or Python applications.

Yes — raising the floor from 0.13 to 0.14 means this package no longer installs alongside openjd-model 0.13.x. Consumers pinned to openjd-model < 0.14 will need to widen their own caps.

Does this change impact security?

  • Does the change need to be threat modeled? For example, does it create or modify files/directories that must only be readable by the process owner?
    • If so, then please label this pull request with the "security" label. We'll work with you to analyze the threats.

No.

Cross-port to openjd-rs

This package is being migrated to Rust in openjd-rs/crates/openjd-sessions.
Behavioral changes made here should be replicated there to keep the two
implementations in sync until the migration is complete.

  • Cross-porting is not applicable for this change because: dependency pin update only — no runtime behavior change.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: Sean Tang <171081544+seant-aws@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown

Claude review · advisory

Reviewed c265762 (full review): 0 findings.

Open: 0 blocking · 0 should-fix · 0 nit. ✅ Nothing blocking.

Fix or reply to each thread; the next revision's review re-checks open threads and resolves those it agrees are handled. Resolving a thread yourself also closes it. Later revisions review only what changed.

@seant-aws
seant-aws merged commit 7877e65 into OpenJobDescription:mainline Oct 19, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants