Repository navigation
feat!: Require openjd-model 0.14 - #372
Merged
seant-aws merged 1 commit intoOct 19, 2026
Merged
Conversation
Signed-off-by: Sean Tang <171081544+seant-aws@users.noreply.github.com>
|
Claude review · advisory Reviewed Open: 0 blocking · 0 should-fix · 0 nit. ✅ Nothing blocking. Fix or reply to each thread; the next revision's review re-checks open threads and resolves those it agrees are handled. Resolving a thread yourself also closes it. Later revisions review only what changed. |
AlexTranAmz
approved these changes
Oct 19, 2026
godobyte
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: N/A — dependency maintenance
What was the problem/requirement? (What/Why)
openjd-model 0.14.0 was released on 2026-10-16, but the openjd-model dependency range in this package (
>= 0.13, < 0.14) prevents resolving it.What was the solution? (How)
Widen the openjd-model dependency range from
>= 0.13, < 0.14to>= 0.14, < 0.15.What is the impact of this change?
Consumers of this package will resolve openjd-model 0.14.x instead of 0.13.x. openjd-model 0.14.0 brings Rust crate bumps (expr 0.12.0, model 0.13.0, sessions 0.8.1), stricter template validation, and a Pydantic 2.14 typing fix.
How was this change tested?
See DEVELOPMENT.md for information on running tests.
Yes —
hatch run test: 1009 passed, 46 skipped, 16 xfailed.hatch run lint: clean (ruff + mypy, 94 source files). No code changes required.Was this change documented?
N/A — no code changes, only a version pin update and its associated comment.
Is this a breaking change?
A breaking change is one that modifies a public contract in a way that is not backwards compatible. See the
Public Interfaces section
of the DEVELOPMENT.md for more information on the public contracts.
If so, then please describe the changes that users of this package must make to update their scripts, or Python applications.
Yes — raising the floor from 0.13 to 0.14 means this package no longer installs alongside openjd-model 0.13.x. Consumers pinned to openjd-model < 0.14 will need to widen their own caps.
Does this change impact security?
No.
Cross-port to openjd-rs
This package is being migrated to Rust in
openjd-rs/crates/openjd-sessions.Behavioral changes made here should be replicated there to keep the two
implementations in sync until the migration is complete.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.