Apply __OpenModelica_simulationFlags to wasm-jit - #294
Merged
Conversation
The wasm-jit runtime honours `-alarm`, but `fixData` only handed the flag to `simCodeTarget=C`, so wasm-jit runs had no wall-clock limit and kept going until the harness' own much larger timeout. Models such as ScalableTestSuite's CocurrentHeatExchangerEquations_N_1280 ran for ten minutes instead of stopping at the configured `ulimitExe` of 300s. Co-authored-by: Claude <noreply@anthropic.com>
The annotation was only read for `simCodeTarget=C`, so a model asking for a specific solver got it in the C run and the default `dassl` in the wasm-jit one. That is not a like-for-like comparison, and where the annotation exists it is usually there because the default solver copes badly: ScalableTestSuite's CocurrentHeatExchangerEquations asks for `ida` (sparse, KLU), and dassl's dense factorization made the wasm-jit runs scale cubically instead of linearly. | N | dassl | ida (annotation) | C, ida | | ---- | ------ | ---------------- | ------ | | 320 | 3.7s | 0.34s | 0.4s | | 640 | 31.9s | 1.01s | 0.85s | | 1280 | >600s | 2.82s | 1.9s | The C path validates each flag by running the HelloWorld executable with it. wasm-jit builds no executable — the runtime is inside omc — so probe it there instead, by simulating a trivial model through the session that is already open. Co-authored-by: Claude <noreply@anthropic.com>
sjoelund
enabled auto-merge (squash)
August 7, 2026 09:07
sjoelund
disabled auto-merge
August 7, 2026 09:07
sjoelund
enabled auto-merge (rebase)
August 7, 2026 09:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also add the missing -alarm for the simulation itself