Conversation
- the blending layer is used only for calculating terraforming barriers. There is no need to store it. Reduces server memory consumption by 260 MB in the current zone configuration.
Contributor
|
Honestly, I'm unsure about that. From what I know, blend layer is used to store terraforming data and 'degrading' island to it's original state. We have to be extremely careful touching that. and if in return we only get 260MB of RAM it might not worth it. Please evaluate potential impact. |
clouths
approved these changes
Sep 28, 2026
clouths
left a comment
Collaborator
There was a problem hiding this comment.
The changes looks good.
@Sellafield I've done an impact analysis. The restore-to-original-state path doesn't touch the blend layer:
ZoneRestoreOriginalGammarestores fromTerraformableAltitude.OriginalAltitudewhich is a separate layer that stays retained which this PR does not touch. ThePBSHelperreadsOriginalAltitudetoo.- The blend layer has exactly one read site in the codebase
TerraformtableAltitudeconstructor, where it's mixed with the original altitude once, at zone load, to derive theBarrierlayer (per-cell min/max clamp)
Having said that, it would be nice to add a test on the CalculateBarrier. Ex: A small test that builds a TerraformableAltitude from hand-made arrays, assert Barrier min/max on a few cells. This would guard the barrier clamp logic that OnUpdating depends on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The blending layer is used only for calculating terraforming barriers. There is no need to store it. Reduces server memory consumption by 260 MB in the current zone configuration.