Optimization of layer reading/saving - #65
Merged
Merged
Conversation
aqpanaciy
commented
Sep 23, 2026
aqpanaciy
commented
Collaborator
- сalculate the hash of a layer data file without loading it into memory;
- write the array with layer data directly, while simultaneously calculating its hash;
- ReadLayer now opens the file and streams bytes directly into a T[] .
- сalculate the hash of a layer data file without loading it into memory; - write the array with layer data directly, while simultaneously calculating its hash. Co-Authored-By: Google Gemini <gemini@google.com>
ReadLayer now opens the file and streams bytes directly into a T[] for blittable structs to avoid an extra intermediate byte[] allocation. It uses MemoryMarshal.AsBytes and RuntimeHelpers.IsReferenceOrContainsReferences to choose the fast path, handles zero-length files, and falls back to the original ReadAllBytes->ToArray<T>() logic when the file size isn't a sizeof(T) multiple, the type contains references, or a partial read occurs. Added necessary using directives. Keeps behavior compatible while reducing allocations for raw binary layer files. Co-Authored-By: Copilot <198982749+Copilot@users.noreply.github.com>
Sellafield
approved these changes
Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.