ppdc-source: fix potential null dereference - #1673
Open
dhejyuyr wants to merge 1 commit into
Open
Conversation
Add null checks for manufacturer and model_name to prevent a potential null dereference. Signed-off-by: Elizaveta Tereshkina <teryoshkina.ea@gmail.com>
houranled
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the PPD import utility, according to the
import_ppd()function, the values ofdriver->manufactureranddriver->model_namemight be a null pointer, which could lead to the dereference ofd->manufacturerandd->model_namein thewrite_file()function. Alsod->manufactureris usually checked before dereference. It may be not that major, but I haven't able to prove otherwise. My commit perhaps breaks the structure of a writing file, but I relied on the example of a debug print for null values.