Repository navigation
Conversation
cupsCopyString does not initialize bytes after the terminating null. For a one-character language name such as the C locale, checking langname[2] therefore branches on an uninitialized stack byte. Check the string length before normalizing the separator.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cupsLangFind()copies the requested language into a 16-byte stack buffer and then checkslangname[2]for'-'.cupsCopyString()only initializes the copied bytes and the terminating null. For a one-character name such as the POSIX"C"locale,langname[2]is therefore still uninitialized.This is also reached through
cupsLangDefault()whenever the process locale is"C".Reproducer
Build the existing
testlangprogram and run a lookup for the"C"locale under Valgrind:Memcheck reports:
Check the copied string length before inspecting index 2. The same command is Memcheck-clean after the change, and
testlangpasses.