Skip to content

Fix: use curl instead of checkout for en-GB.txt #3490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gymnasiast merged 3 commits into from
Aug 1, 2026
Merged

Fix: use curl instead of checkout for en-GB.txt #3490

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e8d4e6d
perf: fetch en-GB.txt via curl instead of repo checkout
Davis-3450 Jul 9, 2026
fccee5a
chire: remove old step
Davis-3450 Jul 9, 2026
48bc61a
en-ci: add fail hard option to curl
Davis-3450 Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions .github/workflows/translation_check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,10 @@ jobs:
ref: ${{github.event.pull_request.head.ref}}
repository: ${{github.event.pull_request.head.repo.full_name}}

- name: Get OpenRCT2 develop (for en-GB.txt)
uses: actions/checkout@v4
with:
repository: OpenRCT2/OpenRCT2
ref: develop
path: OpenRCT2
- name: get en-GB.txt (curl)
run: |
mkdir -p OpenRCT2/data/language
curl -sSLf https://raw.githubusercontent.com/OpenRCT2/OpenRCT2/develop/data/language/en-GB.txt -o OpenRCT2/data/language/en-GB.txt

@tupaschoal tupaschoal Jul 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the motivation for not checking out everything so that it can be faster, but I'm not sure using curl is the best option, since we need to work with GH's URL. GitHub actions provides a way to checkout only a given file, so we could instead do:

Suggested change
curl -sSLf https://raw.githubusercontent.com/OpenRCT2/OpenRCT2/develop/data/language/en-GB.txt -o OpenRCT2/data/language/en-GB.txt
- name: Get OpenRCT2 develop (for en-GB.txt)
uses: actions/checkout@v4
with:
repository: OpenRCT2/OpenRCT2
ref: develop
path: OpenRCT2
sparse-checkout: |
data/language/en-GB.txt
sparse-checkout-cone-mode: false

@Gymnasiast Gymnasiast Aug 1, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub’s URLs haven’t changed much over the years, so I’m comfortable doing it like this. As such, I’ll merge it, but we can revisit it if necessary.

@tupaschoal tupaschoal Aug 1, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not my suggestion? Seemed more "native"

@Davis-3450 Davis-3450 Aug 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well if you consider the size of the main repo, it can make an important difference.

If it doesn't work we can always revert it.

@tupaschoal tupaschoal Aug 1, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand, but so does my suggestion, it only checks out a single file doesn't it?

@Davis-3450 Davis-3450 Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it cloned the entire repo.


- name: Checkout translations before PR changes (for comparsion)
uses: actions/checkout@v4
Expand Down