Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/unhandled-rejection-stream-abort.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@openrouter/agent': patch
---

Prevent unhandled promise rejection crash when aborting a tool-enabled stream.
3 changes: 3 additions & 0 deletions packages/agent/src/lib/model-result.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1098,6 +1098,9 @@ export class ModelResult<
}
broadcaster.complete();
});
// Attach an immediate rejection handler so early consumer exit (such as an abort)
// does not leave executionPromise as an unhandled promise rejection.
void executionPromise.catch(() => {});
return {
consumer,
executionPromise,
Expand Down
60 changes: 60 additions & 0 deletions packages/agent/tests/unit/run-cancellation.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -389,4 +389,64 @@ describe('per-request timeoutMs composition', () => {
expect(text).toBe('done');
expect(mockBetaResponsesSend).toHaveBeenCalledTimes(2);
});

it('does not emit unhandledRejection when aborting a tool-enabled stream', async () => {
const unhandledRejections: unknown[] = [];
const onUnhandled = (err: unknown) => {
unhandledRejections.push(err);
};
process.on('unhandledRejection', onUnhandled);

try {
const controller = new AbortController();
let streamController!: ReadableStreamDefaultController<models.StreamEvents>;
const stream = new ReadableStream<models.StreamEvents>({
start(c) {
streamController = c;
},
});

mockBetaResponsesSend.mockImplementation(async (_client, _req, options) => {
options.signal?.addEventListener('abort', () => {
streamController.error(options.signal?.reason ?? new Error('Aborted'));
});
return {
ok: true,
value: stream,
};
});

const result = callModel(client, {
model: 'test-model',
input: 'hello',
tools: [
echoTool,
],
signal: controller.signal,
});

let streamError: unknown;
try {
streamController.enqueue({
type: 'response.output_text.delta',
delta: 'chunk',
sequenceNumber: 0,
} as models.StreamEvents);

for await (const _event of result.getFullResponsesStream()) {
controller.abort(new DOMException('This operation was aborted', 'AbortError'));
}
} catch (err) {
streamError = err;
}

expect(streamError).toBeDefined();

await new Promise((resolve) => setTimeout(resolve, 50));

expect(unhandledRejections).toHaveLength(0);
} finally {
process.off('unhandledRejection', onUnhandled);
}
});
});