Add SLH-DSA keygen fallback without wrap attributes - #687
Merged
Merged
Conversation
Reuse the no-wrap key template fallback for ML-DSA, ML-KEM, and SLH-DSA. Thales Luna and Entrust nShield HSMs are known to require this fallback for some PQC key types because they reject CKA_WRAP or CKA_UNWRAP.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related Issue
Fixes #685
Current Behavior
SLH-DSA key generation fails on HSMs that reject
CKA_WRAPorCKA_UNWRAP.New Behavior
Retry SLH-DSA key generation without these attributes, using the same fallback as ML-DSA and ML-KEM.
Scope of Changes
Testing
Not tested with SLH-DSA because I do not have access to a token that supports SLH-DSA.
Additional Notes
License Declaration