Skip to content

rebase to serenity@next - #42

Merged
Kuuuube merged 9 commits into
OpenTabletDriver:masterfrom
jamesbt365:serenity@next
Nov 19, 2026
Merged

Kuuuube merged 9 commits into
OpenTabletDriver:masterfrom
jamesbt365:serenity@next

Conversation

@jamesbt365

@jamesbt365 jamesbt365 commented Jun 20, 2024 •

Copy link
Copy Markdown
Member

Uhhhhh

supersedes #41

As the above PR, will not compile as is. Waiting on rustc update in nixpkgs.

Rundown of the fun

  • Bumps dependencies
  • removes more allocations
  • fixes silly lifetime issues caused by CreateEmbed with internal references
  • removes remnants of TypeMap
  • use let Some(x) conditions in more places where diversion already happened

I could tweak the interaction code here but I already opened issues to clean it up (#36 and #32)

May open an additional PR in the future to use FixedStrings we can, I don't wanna mess around with the pagination logic and the matching logic (which mutates a string so I can't just throw it everywhere)

@Kuuuube
Kuuuube merged commit e17e41e into OpenTabletDriver:master Nov 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants