Survive the openvox repo's broken nested tags when picking a release - #473
Closed
miharp wants to merge 1 commit into
Closed
Survive the openvox repo's broken nested tags when picking a release#473miharp wants to merge 1 commit into
miharp wants to merge 1 commit into
Conversation
The git gem 5.x bump (OpenVoxProject#472) broke every reference build that resolves the newest release tag itself (any `rake references:*` without an explicit VERSION). Git::Base#tags re-resolves each tag name and, since 5.x, raises on the literal `tags/2.6.0rc1..3` tags that exist in the upstream openvox repository: Git::UnexpectedResultError: Tag 'tags/tags/2.6.0rc1' does not exist. The gem offers no non-raising listing (Git::Base#lib is deprecated and delegates back to the same path), so list tag names with a plain `git tag --list` and parse those; names that are not versions are discarded, which also replaces the old trick of mapping them to version 0. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Michael Harp <mike@mikeharp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#472 bumped the
gitgem from~> 4.0to~> 5.2, andGemfile.lockis not committed, so CI and fresh local setups now resolve git 5.x. That breaksRepo#newest_release, which everyrake references:*invocation without an explicitVERSIONgoes through: git 5.x'sGit::Base#tagsre-resolves each tag name while enumerating and raises on the literaltags/2.6.0rc1,tags/2.6.0rc2, andtags/2.6.0rc3tags that exist in the upstream openvox repository (a fresh clone has them, so CI hits it too):Git::UnexpectedResultError: Tag 'tags/tags/2.6.0rc1' does not exist.First seen on #468's CI, whose series feature routes
VERSION=8.xthrough the same resolution (failing run), but master is equally affected for the default no-VERSIONpath.The gem offers no non-raising listing (
Git::Base#libis deprecated in 5.x and delegates back to the same path), sonewest_releasenow lists names with a plaingit tag --list(newtag_nameshelper) and parses those, discarding non-version names viafilter_mapinstead of mapping them to version 0.Verified locally against git 5.2.0:
newest_releaseresolves8.28.1from the vendored openvox clone (which carries the three junk tags), and a fullbundle exec rake references:openvoxrun completes.Worth passing to the openvox maintainers separately: deleting the three
tags/2.6.0rc*tags from the repository would remove the hazard at the source.Assisted by Claude.