Repository navigation
chore: add CLAUDE.md, rewrite contributor guide, add PR CI [skip ci] - #343
Merged
Merged
Conversation
- Rewrite .github/copilot-instructions.md to match the current code. It described the pre-v4 layout (src/switchbot-ble.ts, src/device.ts, SwitchBotBLE/SwitchBotOpenAPI, "12 tests", async-mutex), none of which exist any more. - Document how to port a pySwitchbot release, with a file-by-file map between the two codebases and the follow-up PRs for homebridge-switchbot and SwitchBotAPI-BLE. - Record the known DEVICE_MODEL_MAP drift from pySwitchbot. - Add CLAUDE.md, which imports the guide so Claude Code and Copilot share one source of truth. No code changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TYWa2RXoWsaUTWh76oNv8s
Pull requests had no CI; checks only ran on pushes to beta branches. Add a CI workflow for PRs to latest and beta-* on Node 22 and 24, and document the [skip ci] title convention for docs/tooling-only PRs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TYWa2RXoWsaUTWh76oNv8s
donavanbecker
changed the title
The previous commit message quoted the skip-ci token, which made GitHub skip CI for this branch. This empty commit lets the new workflow run. It disappears when the PR is squash-merged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TYWa2RXoWsaUTWh76oNv8s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
.github/copilot-instructions.mdto match the current code. It still described the pre-v4 layout (src/switchbot-ble.ts,src/device.ts,SwitchBotBLE/SwitchBotOpenAPI, "12 tests",async-mutex), none of which exist any more.DEVICE_MODEL_MAPdrift from pySwitchbot (e.g. Meter Proovs4) so it is fixed deliberately, in its own PR..github/workflows/ci.yml): build, test and lint on Node 22 and 24 for PRs tolatestandbeta-*. Until now PRs had no checks at all.[skip ci]title convention for changes that don't affect the published package.CLAUDE.md, which imports the guide so Claude Code and Copilot share one source of truth.Notes
[skip ci]so the squash merge tolatestdoes not cut an empty release (same mechanism as chore(release): v5.0.0 [skip ci] #342). The new CI still runs on this PR.https://claude.ai/code/session_01TYWa2RXoWsaUTWh76oNv8s
Generated by Claude Code